From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Date: Sun, 16 Oct 2016 21:51:08 +0300 Message-ID: <83mvi4yvoj.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1476643949 2895 195.159.176.226 (16 Oct 2016 18:52:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Oct 2016 18:52:29 +0000 (UTC) Cc: 24706@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 16 20:52:25 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvqXY-0006cE-LH for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 20:52:08 +0200 Original-Received: from localhost ([::1]:57476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvqXa-0004ff-QA for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 14:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvqXV-0004fP-5r for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:52:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvqXS-0002ca-4r for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvqXS-0002cW-1C for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bvqXR-0008Ol-Qw for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2016 18:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24706-submit@debbugs.gnu.org id=B24706.147664388132227 (code B ref 24706); Sun, 16 Oct 2016 18:52:01 +0000 Original-Received: (at 24706) by debbugs.gnu.org; 16 Oct 2016 18:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:35455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvqWn-0008Nj-F5 for submit@debbugs.gnu.org; Sun, 16 Oct 2016 14:51:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvqWk-0008NV-5A for 24706@debbugs.gnu.org; Sun, 16 Oct 2016 14:51:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvqWb-0002E8-Qa for 24706@debbugs.gnu.org; Sun, 16 Oct 2016 14:51:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvqWb-0002E2-Mn; Sun, 16 Oct 2016 14:51:09 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bvqWa-0007DA-V7; Sun, 16 Oct 2016 14:51:09 -0400 In-reply-to: (message from Philipp Stephani on Sun, 16 Oct 2016 18:25:08 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124564 Archived-At: > From: Philipp Stephani > Date: Sun, 16 Oct 2016 18:25:08 +0000 > > Attached a patch that uses the wording from `define-minor-mode'. The patch for the ELisp manual simply rearranges the same words, so it's not clear to me why we would prefer it to what's already there. As for the doc string, please avoid repetition, it's confusing. I suggested to describe the additional features when the mode is called from Lisp by using the word "also". Thanks.