all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 24706@debbugs.gnu.org
Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking
Date: Sun, 16 Oct 2016 21:51:08 +0300	[thread overview]
Message-ID: <83mvi4yvoj.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkROpAJRdp2GyY6_dKcd0VYoBfM_Z31wi22Uok-O5ry40w@mail.gmail.com> (message from Philipp Stephani on Sun, 16 Oct 2016 18:25:08 +0000)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 16 Oct 2016 18:25:08 +0000
> 
> Attached a patch that uses the wording from `define-minor-mode'. 

The patch for the ELisp manual simply rearranges the same words, so
it's not clear to me why we would prefer it to what's already there.

As for the doc string, please avoid repetition, it's confusing.  I
suggested to describe the additional features when the mode is called
from Lisp by using the word "also".

Thanks.





  reply	other threads:[~2016-10-16 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16 15:45 bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Philipp Stephani
2016-10-16 16:12 ` Drew Adams
2016-10-16 16:31   ` Noam Postavsky
2016-10-16 16:49     ` Drew Adams
2016-10-16 18:01     ` Eli Zaretskii
2016-10-16 18:13   ` Philipp Stephani
2016-10-16 18:25     ` Philipp Stephani
2016-10-16 18:51       ` Eli Zaretskii [this message]
2017-04-23 17:51         ` Philipp Stephani
2017-04-26 11:26           ` Eli Zaretskii
2020-08-01 20:47             ` Philipp Stephani
2020-08-02 16:13               ` Eli Zaretskii
2020-10-01 12:12                 ` Stefan Kangas
2016-10-16 18:53     ` Eli Zaretskii
2016-10-16 19:50     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mvi4yvoj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24706@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.