From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 24923@debbugs.gnu.org
Subject: bug#24923: 25.1; Lisp watchpoints
Date: Sun, 20 Nov 2016 17:58:17 +0200 [thread overview]
Message-ID: <83mvgu9m92.fsf@gnu.org> (raw)
In-Reply-To: <874m32lx1e.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)
> From: npostavs@users.sourceforge.net
> Cc: 24923@debbugs.gnu.org
> Date: Sat, 19 Nov 2016 21:12:13 -0500
>
> Eli Zaretskii <eliz@gnu.org> writes:
> >
> > Our coding conventions put the logical operators at the beginning of a
> > line, not at EOL.
>
> Fixed this, and added documentation. Also, watcher functions are now
> listed in describe-variable output.
Thanks.
> Does it make sense to mention the use of the `watchers' symbol property
> in the manual? Since I've added a `get-variable-watchers' it's now
> possible to ignore the symbol property as an implementation detail.
I think the property can indeed be left undocumented.
> @@ -1233,13 +1233,14 @@ DEFUN ("set", Fset, Sset, 2, 2, 0,
> If buffer/frame-locality is an issue, WHERE specifies which context to use.
> (nil stands for the current buffer/frame).
>
> - If BINDFLAG is false, then if this symbol is supposed to become
> - local in every buffer where it is set, then we make it local.
> - If BINDFLAG is true, we don't do that. */
> + If BINDFLAG is SET_INTERNAL_SET, then if this symbol is supposed to
> + become local in every buffer where it is set, then we make it
> + local. If BINDFLAG is SET_INTERNAL_BIND or SET_INTERNAL_UNBIND, we
> + don't do that. */
What are those SET_INTERNAL_* values? They are numbers, right? Then
they should be described as such in the doc string.
> +(defun cancel-debug-on-variable-change (&optional variable)
> + "Undo effect of \\[debug-on-entry] on VARIABLE.
^^^^^^^^^^^^^^^^^^
Copy/paste error.
I will comment on the documentation in a separate message.
next prev parent reply other threads:[~2016-11-20 15:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 3:10 bug#24923: 25.1; Lisp watchpoints npostavs
2016-11-11 10:02 ` Eli Zaretskii
2016-11-12 4:34 ` npostavs
2016-11-12 7:19 ` Eli Zaretskii
2016-11-13 0:54 ` npostavs
2016-11-13 15:29 ` Eli Zaretskii
2016-11-20 2:12 ` npostavs
2016-11-20 10:49 ` Stephen Berman
2016-11-20 14:14 ` npostavs
2016-11-20 16:11 ` Eli Zaretskii
2016-11-20 19:26 ` npostavs
2016-11-20 19:36 ` Eli Zaretskii
2016-11-20 20:16 ` npostavs
2016-11-21 17:31 ` Eli Zaretskii
2016-12-03 1:47 ` npostavs
2016-12-03 3:49 ` Clément Pit--Claudel
2016-12-03 3:50 ` Clément Pit--Claudel
2016-12-03 5:01 ` Daniel Colascione
2016-12-03 14:11 ` npostavs
2016-11-20 15:58 ` Eli Zaretskii [this message]
2016-11-20 17:00 ` npostavs
2016-11-20 17:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvgu9m92.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24923@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.