From: Eli Zaretskii <eliz@gnu.org>
To: Nick Helm <nick@tenpoint.co.nz>
Cc: 26892-done@debbugs.gnu.org
Subject: bug#26892: 25.2; whitespace-mode does not turn off correctly
Date: Fri, 19 May 2017 15:27:52 +0300 [thread overview]
Message-ID: <83mva92fqv.fsf@gnu.org> (raw)
In-Reply-To: <m2a86f2cex.fsf@tenpoint.co.nz> (message from Nick Helm on Mon, 15 May 2017 12:26:14 +1200)
> From: Nick Helm <nick@tenpoint.co.nz>
> CC: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 15 May 2017 12:26:14 +1200
>
> I've written a new test and confirmed it catches this problem. I also
> tweaked the original patch to handle another instance of the same bug.
>
> Patches for whitespace.el and whitespace-tests.el are attached.
Thanks, pushed.
A couple of notes, for the future:
. The test at first failed for me, and needed some tweaking, because
whitespace-mode refuses to turn on in batch mode. I guess you ran
the tests in interactive mode? You should run tests in batch.
. The patch was not applicable without manual editing, because it
used file names like whitespace-a.el, which don't exist. Please in
the future submit patches produced against the correct file names,
preferably with "git diff" or somesuch.
. Please include with the patch a ChangeLog-style commit log message
(see CONTRIBUTE for details).
. Finally, this contribution exhausts the amount of changes we can
accept from you without legal paperwork, so I encourage you to
start the paperwork rolling, for us to be able to accept your
future contributions. (I can send you the forms off-list if you
want.)
Thanks again for working on this.
next prev parent reply other threads:[~2017-05-19 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 23:34 bug#26892: 25.2; whitespace-mode does not turn off correctly Nick Helm
2017-05-12 6:19 ` Eli Zaretskii
2017-05-15 0:26 ` Nick Helm
2017-05-19 12:27 ` Eli Zaretskii [this message]
2017-05-21 23:11 ` Nick Helm
2017-05-22 4:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mva92fqv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26892-done@debbugs.gnu.org \
--cc=nick@tenpoint.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.