From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Mon, 14 Aug 2017 19:33:57 +0300 Message-ID: <83mv72glca.fsf@gnu.org> References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> <83pobygo3d.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502728556 1812 195.159.176.226 (14 Aug 2017 16:35:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Aug 2017 16:35:56 +0000 (UTC) Cc: p.stephani2@gmail.com, 27986@debbugs.gnu.org To: eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 14 18:35:49 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIL3-0007uP-JC for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 18:35:37 +0200 Original-Received: from localhost ([::1]:33013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhIL9-0008Jt-Qs for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 12:35:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhIKZ-0007vx-RY for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 12:35:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhIKU-00040w-Rb for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 12:35:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhIKU-00040V-OP for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 12:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhIKU-00055p-EO for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 12:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2017 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150272845419566 (code B ref 27986); Mon, 14 Aug 2017 16:35:02 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 14 Aug 2017 16:34:14 +0000 Original-Received: from localhost ([127.0.0.1]:35798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIJi-00055W-DE for submit@debbugs.gnu.org; Mon, 14 Aug 2017 12:34:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIJh-00055Q-H9 for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 12:34:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhIJX-0002lq-A2 for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 12:34:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhIJX-0002lW-6p; Mon, 14 Aug 2017 12:34:03 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4573 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhIJW-0001PD-JD; Mon, 14 Aug 2017 12:34:03 -0400 In-reply-to: <83pobygo3d.fsf@gnu.org> (message from Eli Zaretskii on Mon, 14 Aug 2017 18:34:30 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135749 Archived-At: > Date: Mon, 14 Aug 2017 18:34:30 +0300 > From: Eli Zaretskii > Cc: p.stephani2@gmail.com, 27986@debbugs.gnu.org > > There's nothing easier than implementing renameat_noreplace on > MS-Windows, since the underlying system call does that by default, and > it's emulating the Posix behavior that requires complications. In > fact, we already have this implementation: see sys_rename_replace (in > w32.c) which needs to be called with its last argument FALSE (modulo > the "at" part, which is easily handled). Which I just did.