From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28373: [PATCH] New variable controls whether dired confirms to kill buffers visiting deleted files Date: Fri, 08 Sep 2017 12:41:04 +0300 Message-ID: <83mv65y1cf.fsf@gnu.org> References: <87r2vjkf4i.fsf@gmail.com> <83ingv238f.fsf@gnu.org> <87pob3k87y.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1504863769 22074 195.159.176.226 (8 Sep 2017 09:42:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Sep 2017 09:42:49 +0000 (UTC) Cc: 28373-done@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 08 11:42:35 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqFne-00041z-Gf for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Sep 2017 11:42:10 +0200 Original-Received: from localhost ([::1]:44170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqFnl-0001VM-K4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Sep 2017 05:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqFnb-0001TX-1t for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2017 05:42:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqFnW-00051b-EX for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2017 05:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqFnW-00051V-B8 for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2017 05:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqFnW-0003SH-5n for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2017 05:42:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2017 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 28373@debbugs.gnu.org, eliz@gnu.org, alex.branham@gmail.com Original-Received: via spool by 28373-done@debbugs.gnu.org id=D28373.150486367113214 (code D ref 28373); Fri, 08 Sep 2017 09:42:01 +0000 Original-Received: (at 28373-done) by debbugs.gnu.org; 8 Sep 2017 09:41:11 +0000 Original-Received: from localhost ([127.0.0.1]:55318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqFmh-0003R4-38 for submit@debbugs.gnu.org; Fri, 08 Sep 2017 05:41:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqFmf-0003Qp-Oo for 28373-done@debbugs.gnu.org; Fri, 08 Sep 2017 05:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqFmV-0004BU-Ta for 28373-done@debbugs.gnu.org; Fri, 08 Sep 2017 05:41:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqFmV-0004BA-QF; Fri, 08 Sep 2017 05:40:59 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqFmU-0000PM-Vq; Fri, 08 Sep 2017 05:40:59 -0400 In-reply-to: <87pob3k87y.fsf@gmail.com> (message from Alex Branham on Wed, 06 Sep 2017 13:11:45 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136680 Archived-At: > From: Alex Branham > Cc: 28373@debbugs.gnu.org > Date: Wed, 06 Sep 2017 13:11:45 -0500 > > Thanks for the review. I think I've addressed the things you've brought up; specific replies below. Thanks, pushed to the master branch. Two minor nits for the future: . please always mention the bug number in the commit log message . the NEWS entry should be marked with "+++" only if the new feature is described in the appropriate manual; otherwise it should be either marked with "---" (if it doesn't need to be in the manual), or not marked at all (which is a signal for the maintainers to consider documenting it at some future point). This is explained at the beginning of NEWS.