From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Doc string and operation of color-distance Date: Thu, 14 Sep 2017 21:45:45 +0300 Message-ID: <83mv5xm84m.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505414838 24426 195.159.176.226 (14 Sep 2017 18:47:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Sep 2017 18:47:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 14 20:47:09 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsZAK-00067a-DP for ged-emacs-devel@m.gmane.org; Thu, 14 Sep 2017 20:47:08 +0200 Original-Received: from localhost ([::1]:49514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsZAR-00022h-K6 for ged-emacs-devel@m.gmane.org; Thu, 14 Sep 2017 14:47:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsZ9v-00022U-JW for emacs-devel@gnu.org; Thu, 14 Sep 2017 14:46:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsZ9s-0004zm-Hs for emacs-devel@gnu.org; Thu, 14 Sep 2017 14:46:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsZ9s-0004zQ-Ek; Thu, 14 Sep 2017 14:46:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1422 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dsZ97-0001JO-P9; Thu, 14 Sep 2017 14:46:40 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218285 Archived-At: Mark, the new color-distance says something strange in its doc string: (color-distance COLOR1 COLOR2 &optional FRAME METRIC) Return an integer distance between COLOR1 and COLOR2 on FRAME. COLOR1 and COLOR2 may be either strings containing the color name, or lists of the form (RED GREEN BLUE), each in the range 0 to 65535 inclusive. If FRAME is unspecified or nil, the current frame is used. If METRIC is unspecified or nil, a modified L*u*v* metric is used. The last sentence should say "non-nil", I think, and it should document that METRIC is supposed to be a function of 2 colors. Also, this is unexpected: (color-distance "red" "blue" nil 'lcms-cam02-ucs) => (error "Invalid color" "red") I think the new lcms2 functions should support colors specified as strings, because all the other color-related functions do.