From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: JSON/YAML/TOML/etc. parsing performance Date: Sun, 01 Oct 2017 21:38:18 +0300 Message-ID: <83mv5a3e91.fsf@gnu.org> References: <87poaqhc63.fsf@lifelogs.com> <8360ceh5f1.fsf@gnu.org> <83h8vl5lf9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506883115 7479 195.159.176.226 (1 Oct 2017 18:38:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Oct 2017 18:38:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 01 20:38:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyj8H-0001VI-Oy for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 20:38:30 +0200 Original-Received: from localhost ([::1]:49505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyj8O-00023l-T5 for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 14:38:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyj8I-00023W-A1 for emacs-devel@gnu.org; Sun, 01 Oct 2017 14:38:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyj8F-0005uT-Dc for emacs-devel@gnu.org; Sun, 01 Oct 2017 14:38:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyj8F-0005uJ-9f; Sun, 01 Oct 2017 14:38:27 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dyj8D-0007Ho-Lz; Sun, 01 Oct 2017 14:38:27 -0400 In-reply-to: (message from Philipp Stephani on Sat, 30 Sep 2017 22:02:55 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218991 Archived-At: > From: Philipp Stephani > Date: Sat, 30 Sep 2017 22:02:55 +0000 > Cc: emacs-devel@gnu.org One more comment: > +static Lisp_Object > +json_insert (void *data) > +{ > + const struct json_buffer_and_size *buffer_and_size = data; > + if (buffer_and_size->size > PTRDIFF_MAX) > + xsignal1 (Qoverflow_error, build_string ("buffer too large")); > + insert (buffer_and_size->buffer, buffer_and_size->size); > + return Qnil; Shouldn't we follow the call to 'insert' with decode_from_gap, or do it before json_insert_callback returns? Or do we trust Jansson to produce 100% valid UTF-8? Thanks.