From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Lisp primitives and their calling of the change hooks Date: Sun, 07 Jan 2018 18:47:41 +0200 Message-ID: <83mv1p8vki.fsf@gnu.org> References: <20180104155111.GB6846@ACM> <20180104211154.GC6846@ACM> <20180106151839.GB23284@ACM> <20180106202403.GD23284@ACM> <20180107113628.GA22254@ACM> <83o9m599du.fsf@gnu.org> <20180107120859.GB22254@ACM> <20180107135629.GC22254@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1515343618 3511 195.159.176.226 (7 Jan 2018 16:46:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Jan 2018 16:46:58 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 07 17:46:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYE5t-0008Su-2J for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 17:46:45 +0100 Original-Received: from localhost ([::1]:58744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYE7s-0003rk-B0 for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 11:48:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYE77-0003rJ-3h for emacs-devel@gnu.org; Sun, 07 Jan 2018 11:48:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYE72-0005hh-Vj for emacs-devel@gnu.org; Sun, 07 Jan 2018 11:48:01 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYE72-0005hb-RV; Sun, 07 Jan 2018 11:47:56 -0500 Original-Received: from [176.228.60.248] (port=1634 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYE72-0007Q2-9X; Sun, 07 Jan 2018 11:47:56 -0500 In-reply-to: <20180107135629.GC22254@ACM> (message from Alan Mackenzie on Sun, 7 Jan 2018 13:56:29 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221675 Archived-At: > Date: Sun, 7 Jan 2018 13:56:29 +0000 > From: Alan Mackenzie > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > > > > zlib-decompress-region calls del_range, which calls the hooks. Or am > > > I missing something? > > > Yes, you're right, sorry. There are change-hook calls for the second, > > deletion, part of the operation. No hooks are called for the first > > part, the insertion of the decompressed text into the buffer. So > > zlib-decompress-region is still not right. > > > I'm going to take a careful look for any more such primitives, which > > have one balanced pair of change hook calls, yet these calls only cover > > part of the operation. > > There appear to be no more such primitives. > > Should I try to fix zlib-decompress-region? How do you want to fix it? That function inserts the decompressed stuff, then deletes the original compressed stuff. What do you want that to produce in terms of the change hooks?