all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, 30106@debbugs.gnu.org
Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106)
Date: Thu, 18 Jan 2018 17:23:29 +0200	[thread overview]
Message-ID: <83mv1bur66.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkSoPi1tdG8tssn4yZhE_eQpMqzcyHgjnEkVt4Y3UA=rUg@mail.gmail.com> (message from Philipp Stephani on Thu, 18 Jan 2018 14:23:03 +0000)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 18 Jan 2018 14:23:03 +0000
> Cc: phst@google.com, 30106@debbugs.gnu.org
> 
>  I'd prefer that the only file that calls systhread.c functions is
>  thread.c; systhread.c is supposed to be low-level code concealed from
>  application levels.  So this would call for another level of
>  indirection: add a new function to thread.c, and call that from
>  emacs-module.c.
> 
> Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules.

Thanks.

>  Otherwise, LGTM for master; thanks.
> 
> Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads
> --with-modules (on some systems at least). 

How important is this?  --with-modules is an opt-in switch, and the
default is to build with threads.  So this sounds not very important
to me, and the change, although simple, is not really trivial, and
will affect any module.  So I'm uneasy putting this on emacs-26,
especially since the Emacs 26.0.91 tarball is already ready and is
awaiting upload, so this will only go into the next pretest, which I
hoped could be a release candidate...

Do you think leaving this for the next release will be so bad?





  reply	other threads:[~2018-01-18 15:23 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  6:36 bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Jean Louis
2018-01-14 16:08 ` Eli Zaretskii
2018-01-14 17:47   ` Jean Louis
2018-01-14 19:44     ` Eli Zaretskii
2018-01-14 22:12       ` Jean Louis
2018-01-15 13:14         ` Eli Zaretskii
2018-01-15 17:56           ` Glenn Morris
2018-01-18 19:35             ` Philipp Stephani
2018-01-18 23:00               ` Glenn Morris
2018-01-15 18:09           ` Jean Louis
2018-01-15 18:55           ` Jean Louis
2018-01-15 20:15             ` Eli Zaretskii
2018-01-16  5:17               ` Jean Louis
2018-01-16 18:06                 ` Glenn Morris
2018-01-16 19:17                   ` Jean Louis
2018-01-16 18:10             ` Eli Zaretskii
2018-01-16 19:18               ` Jean Louis
2018-01-17 15:36                 ` Eli Zaretskii
2018-01-17 17:03                   ` Jean Louis
2018-01-17 18:25                     ` Eli Zaretskii
2018-01-17 18:51                       ` Glenn Morris
2018-01-17 18:58                         ` Glenn Morris
2018-01-17 19:37                           ` Jean Louis
2018-01-18 23:01                             ` Glenn Morris
2018-01-17 20:05                         ` Eli Zaretskii
2018-01-17 20:29                           ` Glenn Morris
2018-01-17 22:16                             ` Philipp Stephani
2018-01-17 22:18                               ` Philipp Stephani
2018-01-17 22:28                                 ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-17 22:28                                   ` bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Philipp Stephani
2018-01-18 14:04                                     ` Eli Zaretskii
2018-01-18 14:23                                       ` Philipp Stephani
2018-01-18 15:23                                         ` Eli Zaretskii [this message]
2018-01-18 17:41                                           ` Glenn Morris
2018-01-18 18:53                                             ` Eli Zaretskii
2018-01-18 22:55                                               ` Glenn Morris
2018-01-19  7:58                                                 ` Eli Zaretskii
2018-01-20 18:07                                                   ` Glenn Morris
2018-01-20 19:01                                                     ` Eli Zaretskii
2018-01-18 19:25                                           ` Philipp Stephani
2018-01-17 22:35                                   ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-18 13:59                               ` bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Eli Zaretskii
2018-01-18 17:40                               ` Glenn Morris
2018-01-17 19:20                       ` Jean Louis
2018-01-17 18:32                     ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mv1bur66.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30106@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.