From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Fri, 19 Jan 2018 17:33:30 +0200 Message-ID: <83mv19ualx.fsf@gnu.org> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <86r2ql28u3.fsf@phe.ftfl.ca> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516375970 21626 195.159.176.226 (19 Jan 2018 15:32:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Jan 2018 15:32:50 +0000 (UTC) Cc: eggert@cs.ucla.edu, ashish@FreeBSD.org, emacs-devel@gnu.org To: Joseph Mingrone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 19 16:32:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecYeQ-0003m5-B9 for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 16:32:18 +0100 Original-Received: from localhost ([::1]:55840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecYgQ-0005hm-63 for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 10:34:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecYgE-0005go-38 for emacs-devel@gnu.org; Fri, 19 Jan 2018 10:34:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecYg9-0008Oj-CY for emacs-devel@gnu.org; Fri, 19 Jan 2018 10:34:10 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecYfw-0008KW-Fg; Fri, 19 Jan 2018 10:33:52 -0500 Original-Received: from [176.228.60.248] (port=2309 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecYfv-00046w-PR; Fri, 19 Jan 2018 10:33:52 -0500 In-reply-to: <86r2ql28u3.fsf@phe.ftfl.ca> (message from Joseph Mingrone on Fri, 19 Jan 2018 10:59:16 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222088 Archived-At: > From: Joseph Mingrone > Cc: emacs-devel@gnu.org, eggert@cs.ucla.edu, ashish@FreeBSD.org > Date: Fri, 19 Jan 2018 10:59:16 -0400 > > > Thanks. Does the patch below solve the problem? > > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > > index acba9e2..a0ab14f 100644 > > --- a/lisp/emacs-lisp/bytecomp.el > > +++ b/lisp/emacs-lisp/bytecomp.el > > @@ -1933,7 +1933,17 @@ byte-compile-file > > ;; parallel bootstrap), it does not risk getting a > > ;; half-finished file. (Bug#4196) > > (tempfile > > - (make-temp-file (file-name-nondirectory target-file))) > > + ;; If target-file is relative and includes > > + ;; leading directories, make-temp-file will > > + ;; assume those leading directories exist > > + ;; under temporary-file-directory, which might > > + ;; not be true. So strip leading directories > > + ;; from relative file names before calling > > + ;; make-temp-file. > > + (if (file-name-absolute-p target-file) > > + (make-temp-file target-file) > > + (make-temp-file > > + (file-name-nondirectory target-file)))) > > (default-modes (default-file-modes)) > > (temp-modes (logand default-modes #o600)) > > (desired-modes (logand default-modes #o666)) > > It does. Thank you. Thanks, I pushed it to the release branch, from which it will be merged to master.