From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30139: 25.3; Passing callback to align-region raises an error when using `justify` rule Date: Sat, 24 Feb 2018 12:21:04 +0200 Message-ID: <83muzy4rjj.fsf@gnu.org> References: <639293e7-4cd9-9297-1ad6-ceba6697a627@zoho.com> <143166e2-a293-aa23-e53f-44265bccf911@zoho.com> <83woz65h7b.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1519467551 19023 195.159.176.226 (24 Feb 2018 10:19:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Feb 2018 10:19:11 +0000 (UTC) Cc: 30139@debbugs.gnu.org, k.michal@zoho.com To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 24 11:19:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epWv4-0004RM-Sa for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Feb 2018 11:19:06 +0100 Original-Received: from localhost ([::1]:49289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epWx6-0000cA-3C for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Feb 2018 05:21:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epWwx-0000bp-HH for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 05:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epWww-0002TZ-H2 for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 05:21:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epWww-0002TL-Cg for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 05:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1epWww-0002FS-74 for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 05:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Feb 2018 10:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30139-submit@debbugs.gnu.org id=B30139.15194676588613 (code B ref 30139); Sat, 24 Feb 2018 10:21:02 +0000 Original-Received: (at 30139) by debbugs.gnu.org; 24 Feb 2018 10:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:58182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epWws-0002Er-Cm for submit@debbugs.gnu.org; Sat, 24 Feb 2018 05:20:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epWwq-0002Ee-Kh for 30139@debbugs.gnu.org; Sat, 24 Feb 2018 05:20:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epWwk-0002JI-IP for 30139@debbugs.gnu.org; Sat, 24 Feb 2018 05:20:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epWwe-0002GJ-7r; Sat, 24 Feb 2018 05:20:44 -0500 Original-Received: from [176.228.60.248] (port=4630 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1epWwd-0005Np-EB; Sat, 24 Feb 2018 05:20:43 -0500 In-reply-to: <83woz65h7b.fsf@gnu.org> (message from Eli Zaretskii on Wed, 21 Feb 2018 20:30:00 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143632 Archived-At: > Date: Wed, 21 Feb 2018 20:30:00 +0200 > From: Eli Zaretskii > Cc: 30139@debbugs.gnu.org > > > From: Michał Kondraciuk > > Date: Tue, 20 Feb 2018 22:07:10 +0100 > > > > is there any news on the status of this bug? Should I just send the > > patch to emacs-devel? > > Sorry for the delay, I will look at the patch soon. John, could you please have a look at this? Btw, I find the documentation in align.el hard to understand. It sounds like a very powerful feature, but I would have difficulties using it, with the doc strings as my only guidance. Some examples of unclear or confusing documentation: . align-region-separate has this to describe the 'group' method: Each contiguous set of lines where a specific alignment occurs is considered a section for that alignment rule. What is a "contiguous set of lines"? Does it mean non-empty lines, i.e. that groups are separated by empty lines (that's what the example seems to imply)? . align-rules-list has this to describe the 'group' attribute: [...] For alignment rules, these are the characters that will be deleted/expanded for the purposes of alignment. The "alignment character" is always the first character immediately following this parenthesis group. This attribute may also be a list of integers, in which case multiple alignment characters will be aligned, with the list of integers identifying the whitespace groups which precede them. The default for this attribute is 1. Which "this parenthesis group" is being alluded to here? Also, it leaves unexplained how characters are specified by integers, and the meaning of the default value of 1 is thus unclear. So patches to clarify the documentation in align.el are most welcome.