all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: open-{gnutls,network}-stream backwards compatibility
Date: Sat, 12 Jan 2019 13:16:29 +0200	[thread overview]
Message-ID: <83muo6f7n6.fsf@gnu.org> (raw)
In-Reply-To: <m2pnt54i22.fsf@gmail.com> (message from Robert Pluim on Wed, 09 Jan 2019 22:50:13 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 09 Jan 2019 22:50:13 +0100
> 
> Robert Pluim <rpluim@gmail.com> writes:
> 
> >> Sounds OK to me, provided we announce this in NEWS.
> >
> > Nah, we'll spring it on the users unannounced and see what happens :-)
> 
> Proposed changes, on top of the proposed patch for Bug#33780.

Both LGTM, with the minor comments fixed.

> +(defcustom network-stream-use-client-certificates t
> +  "Whether to use client certificates for network connections.

Please add a :version tag to this defcustom.

> +When non-nil, `open-network-stream' will automatically look for
> +matching client certificates (via 'auth-source') for a
> +destination server, if it is called without a :client-certificate
> +keyword.  Default is t.
             ^^^^^^^^^^^^
No need to state that, as Emacs knows that automatically.

Thanks.



  parent reply	other threads:[~2019-01-12 11:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 16:49 open-{gnutls,network}-stream backwards compatibility Robert Pluim
2019-01-02 17:04 ` Eli Zaretskii
2019-01-02 17:47   ` Robert Pluim
2019-01-02 18:07     ` Eli Zaretskii
2019-01-02 18:56       ` Robert Pluim
2019-01-04 14:06         ` Eli Zaretskii
2019-01-04 22:29           ` Robert Pluim
2019-01-05  6:58             ` Eli Zaretskii
2019-01-05  7:36               ` Robert Pluim
2019-01-05  8:40                 ` Eli Zaretskii
2019-01-09 21:50                 ` Robert Pluim
2019-01-10 15:53                   ` Ted Zlatanov
2019-01-10 16:05                     ` Eli Zaretskii
2019-01-12 11:16                   ` Eli Zaretskii [this message]
2019-01-02 18:12     ` Ted Zlatanov
2019-01-02 18:30       ` Eli Zaretskii
2019-01-02 19:18         ` Ted Zlatanov
2019-01-02 19:49           ` Eli Zaretskii
2019-01-02 20:01             ` Robert Pluim
2019-01-02 20:25             ` Ted Zlatanov
2019-01-04 11:15               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83muo6f7n6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.