From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34525: replace-regexp missing some matches Date: Mon, 25 Feb 2019 22:11:57 +0200 Message-ID: <83mumjmxv6.fsf@gnu.org> References: <5a74a337-804e-2590-bffd-43a851f90240@gmail.com> <83zhqtjdtz.fsf@gnu.org> <20190220170722.GA9655@ACM> <83sgwigwxm.fsf@gnu.org> <20190220185850.GB9655@ACM> <83lg2agt0j.fsf@gnu.org> <20190220213003.GC9655@ACM> <83bm35hkqo.fsf@gnu.org> <20190224173746.GA21808@ACM> <83mumlnk8y.fsf@gnu.org> <20190224210058.GB21808@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1890"; mail-complaints-to="usenet@blaine.gmane.org" Cc: daniel.lopez999@gmail.com, monnier@iro.umontreal.ca, 34525@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 25 21:13:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyMck-0000OZ-2O for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Feb 2019 21:13:14 +0100 Original-Received: from localhost ([127.0.0.1]:43762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyMci-0004jG-V8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Feb 2019 15:13:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyMcd-0004j6-51 for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 15:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyMcc-0004t2-Ea for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 15:13:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyMcZ-0004ra-0N; Mon, 25 Feb 2019 15:13:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gyMcY-0003OV-H4; Mon, 25 Feb 2019 15:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Mon, 25 Feb 2019 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34525 X-GNU-PR-Package: emacs,cc-mode Original-Received: via spool by 34525-submit@debbugs.gnu.org id=B34525.155112553012991 (code B ref 34525); Mon, 25 Feb 2019 20:13:02 +0000 Original-Received: (at 34525) by debbugs.gnu.org; 25 Feb 2019 20:12:10 +0000 Original-Received: from localhost ([127.0.0.1]:51763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyMbi-0003NS-5n for submit@debbugs.gnu.org; Mon, 25 Feb 2019 15:12:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyMbf-0003N5-FK for 34525@debbugs.gnu.org; Mon, 25 Feb 2019 15:12:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyMbM-0004Qm-9W; Mon, 25 Feb 2019 15:11:52 -0500 Original-Received: from [176.228.60.248] (port=4499 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gyMbL-0007gI-0i; Mon, 25 Feb 2019 15:11:48 -0500 In-reply-to: <20190224210058.GB21808@ACM> (message from Alan Mackenzie on Sun, 24 Feb 2019 21:00:58 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155777 Archived-At: > Date: Sun, 24 Feb 2019 21:00:58 +0000 > Cc: daniel.lopez999@gmail.com, 34525@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Alan Mackenzie > > > > Sadly, UPDATE_SYNTAX_TABLE sets its internal structure gl_state not for > > > the current contents of position 1948, but the contents of 1948 before > > > the change at the top of the buffer (Bitmap -> SharedBitmap) was made. > > > So it picks up the syntax for the "<" rather than the "B". > > > Are you saying that we've modified buffer text, but > > re_match_2_internal still holds to a C pointer to buffer text before > > the change? > > I don't think that's the case. The relevant buffer pointers/sizes are > calculated (in search_buffer_re) as > > p1 = BEGV_ADDR; > s1 = GPT_BYTE - BEGV_BYTE; > p2 = GAP_END_ADDR; > s2 = ZV_BYTE - GPT_BYTE; > > each time before a search. So you are saying that gl_state uses a stale offset, which should have been updated due to the previous replacements?