From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 17:32:11 +0300 Message-ID: <83mukribkk.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555310948.24928.2@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129472"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, rms@gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 16:33:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG2fa-000XRB-7F for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 16:33:14 +0200 Original-Received: from localhost ([127.0.0.1]:51091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2fZ-0001wZ-3e for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 10:33:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2fP-0001wL-H1 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG2fO-000430-Ku for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49902) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG2fO-00042u-E6 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG2fO-0000Be-54 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.1555338757668 (code B ref 35062); Mon, 15 Apr 2019 14:33:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 14:32:37 +0000 Original-Received: from localhost ([127.0.0.1]:35213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG2ey-0000Ai-RN for submit@debbugs.gnu.org; Mon, 15 Apr 2019 10:32:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG2ew-0000AS-FU for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 10:32:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2eq-0003gN-7v; Mon, 15 Apr 2019 10:32:28 -0400 Original-Received: from [176.228.60.248] (port=2947 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hG2ei-0001ep-Ij; Mon, 15 Apr 2019 10:32:21 -0400 In-reply-to: <1555310948.24928.2@yandex.ru> (message from Konstantin Kharlamov on Mon, 15 Apr 2019 09:49:08 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157659 Archived-At: > Date: Mon, 15 Apr 2019 09:49:08 +0300 > From: Konstantin Kharlamov > Cc: Eli Zaretskii , 35062@debbugs.gnu.org > > IMO in such situations (i.e. when original changes were commited > without any modification anyway) would be nice to commit the original > patch, and then add up further improvements as 2-nd commit. That's true, but this is not such a situation: the original changes were never committed without any modifications. Sometimes committing the original and then making changes in a followup is TRT, and sometimes it isn't; it's a judgment call. In general, the decision depends on the percentage of the original submission that the committer would like to change, and also on the overall volume of the original submission. In this case, the original patch was relatively small, and I modified it in relatively significant ways. So it made little sense to commit something that would be immediately modified in significant ways, it would just be extra work for no good reason. > Ultimately what makes me sad is that if I'd want to refer to my > commits in Emacs as part of a CV, it's hard to find all suggested-by > and authored commits at the same time, and also that suggested-by > sounds kind of vague to have an influence in CV. You can always use "git log --grep" to find references to your contributions in the log messages. And the log message includes a reference to the bug number, where you can refer people for your actual contribution.