From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35498: 26.2; doc string of `isearch-regexp-function' Date: Fri, 03 May 2019 18:06:14 +0300 Message-ID: <83muk3mvbt.fsf@gnu.org> References: <<95f9cdd4-4d43-458e-8354-dfc8972b14bf@default>> <<831s1fopq8.fsf@gnu.org>> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="10744"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35498@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 03 23:17:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfYa-0012u5-LV for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 23:17:24 +0200 Original-Received: from localhost ([127.0.0.1]:41946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZmI-00057k-CT for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 11:07:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZmC-00057R-Ok for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 11:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMZmA-0003Uh-Uy for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 11:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMZmA-0003UG-Kk for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMZmA-0002mj-Ay for bug-gnu-emacs@gnu.org; Fri, 03 May 2019 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35498 X-GNU-PR-Package: emacs Original-Received: via spool by 35498-submit@debbugs.gnu.org id=B35498.155689601210690 (code B ref 35498); Fri, 03 May 2019 15:07:02 +0000 Original-Received: (at 35498) by debbugs.gnu.org; 3 May 2019 15:06:52 +0000 Original-Received: from localhost ([127.0.0.1]:49308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZm0-0002mL-AJ for submit@debbugs.gnu.org; Fri, 03 May 2019 11:06:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZly-0002m7-3X for 35498@debbugs.gnu.org; Fri, 03 May 2019 11:06:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZls-00038q-Ev; Fri, 03 May 2019 11:06:44 -0400 Original-Received: from [176.228.60.248] (port=2152 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMZlq-0005v1-8n; Fri, 03 May 2019 11:06:44 -0400 In-reply-to: (message from Drew Adams on Fri, 3 May 2019 07:47:57 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158705 Archived-At: > Date: Fri, 3 May 2019 07:47:57 -0700 (PDT) > From: Drew Adams > Cc: 35498-done@debbugs.gnu.org > > > > The doc string should describe the possible values and their > > > meanings/behaviors. Currently it describes only a function as value. > > > > I added the existing functions that could be used as values. Their > > descriptions are available by using the hyperlink, so no need to > > duplicate that here. The list is, of course, not exhaustive, as Lisp > > programs could define their own functions. > > It should instead, or in addition, specify what args it > must accept and what kind of value it must return. Did you look at the changes I installed? Because I actually did that. > > > Searching isearch.el it seems that this variable can be any of the > > > values possible for `search-default-mode'. Please describe each of the > > > values for `isearch-regexp-function'. > > > > See above: not needed. > > The doc string should say that the value can be t, nil, > or a function. Did you see the changes I install? > > > Even when the value is a function the description could be better, > > > saying that it must accept a string as its first arg and must return a > > > string. That can be surmised from saying that it converts a plain > > > search string to a regexp [search string], but it could be clearer. > > > > Added. > > OK, good. That cancels what I said first, above. So why did you send them anyway?