From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35452: Line number faces should check for remapping of the default face Date: Thu, 16 May 2019 16:57:53 +0300 Message-ID: <83mujmcxi6.fsf@gnu.org> References: <878svvehl1.fsf@gmail.com> <8336lvoqss.fsf@gnu.org> <87a7fmixj1.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99197"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35452@debbugs.gnu.org To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 15:59:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRGug-000Pgh-Bk for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 15:59:14 +0200 Original-Received: from localhost ([127.0.0.1]:58551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRGuf-0001oZ-5e for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 09:59:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRGuU-0001n0-QX for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 09:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRGuT-0008Ly-Up for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 09:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRGuT-0008Lm-Rk for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 09:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRGuT-0005ZN-Pi for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 09:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2019 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35452-submit@debbugs.gnu.org id=B35452.155801509321352 (code B ref 35452); Thu, 16 May 2019 13:59:01 +0000 Original-Received: (at 35452) by debbugs.gnu.org; 16 May 2019 13:58:13 +0000 Original-Received: from localhost ([127.0.0.1]:55980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRGtg-0005YJ-Qb for submit@debbugs.gnu.org; Thu, 16 May 2019 09:58:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRGte-0005Y6-KR for 35452@debbugs.gnu.org; Thu, 16 May 2019 09:58:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRGtZ-0007Y7-Df; Thu, 16 May 2019 09:58:05 -0400 Original-Received: from [176.228.60.248] (port=3372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRGtW-0006ho-8l; Thu, 16 May 2019 09:58:04 -0400 In-reply-to: <87a7fmixj1.fsf@gmail.com> (message from Dario Gjorgjevski on Thu, 16 May 2019 11:00:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159389 Archived-At: [Forwarding to the bug tracker; please use Reply All in the future.] > From: Dario Gjorgjevski > Date: Thu, 16 May 2019 11:00:50 +0200 > > > Thanks, but I don't think I understand the advantages of this approach > > vs the current one. Concretely, why would we want not to inherit > > from the 'default' face? > > Indeed, there is no reason not to inherit from the default face. In > fact, what I suggested was making the inheritance _always hold_, i.e., > despite of the user's definitions of the line number faces. Which > brings us to the next point you brought up... > > > Also, doesn't your change force the line-number face to change > > together with 'default', even if the user defines the face to not > > inherit from 'default'? With the current code, users are free to > > define the face without inheritance, and that will stop update the > > line-number face together with 'default', e.g. when the user enlarges > > the default face's font or makes it smaller. With your proposal, the > > size changes in 'default' will always be propagated to line-number, > > right? > > I agree with you. In fact, this is exactly the reason why I had > suggested the change -- I was using a theme were the line number faces > were not set to inherit from default, and realized that > text-scale-adjust does not affect them. > > > And finally, if we do make the proposed change, shouldn't we stop > > inheriting from 'default' at the same time? > > Absolutely. > > With all this being said, I agree with you that it is best to let the > user choose whether he or she wants the line number faces to inherit > from the default one. So you agree that this bug should be closed without changing the current code? Thanks.