From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36263: Fixed in master Date: Mon, 17 Jun 2019 18:22:10 +0300 Message-ID: <83muigtexp.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214914"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36263@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 17 18:45:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcukp-000tn2-K5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 18:45:11 +0200 Original-Received: from localhost ([::1]:49428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcuko-0000YD-K7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 12:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60291) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hctTM-0000wE-Kk for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 11:23:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hctTK-0002jv-Jv for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 11:23:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hctTK-0002iS-DO for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hctTK-00006y-1Y for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2019 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36263 X-GNU-PR-Package: emacs Original-Received: via spool by 36263-submit@debbugs.gnu.org id=B36263.1560784941360 (code B ref 36263); Mon, 17 Jun 2019 15:23:01 +0000 Original-Received: (at 36263) by debbugs.gnu.org; 17 Jun 2019 15:22:21 +0000 Original-Received: from localhost ([127.0.0.1]:43156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hctSf-00005k-FZ for submit@debbugs.gnu.org; Mon, 17 Jun 2019 11:22:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hctSd-00005W-9M for 36263@debbugs.gnu.org; Mon, 17 Jun 2019 11:22:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hctSN-0001xh-Aa; Mon, 17 Jun 2019 11:22:06 -0400 Original-Received: from [176.228.60.248] (port=2056 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hctSJ-0006nN-RY; Mon, 17 Jun 2019 11:22:02 -0400 In-reply-to: (message from Philipp Stephani on Mon, 17 Jun 2019 14:33:57 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160737 Archived-At: > From: Philipp Stephani > Date: Mon, 17 Jun 2019 14:33:57 +0200 > > This bug is no longer present in master. It would be nice to backport > a fix to the release branch since it's a crashing bug that's quite > easy to trigger. AFAICT, the "fix" on master is quite convoluted, and IMO doesn't really solve the problem, it just makes it harder to reproduce: when HOME is not defined, Emacs 27 calls alternative interfaces, but if those also fail to returns a usable string, it eventually can also return an empty string, and cause the same assertion violation. OTOH, I see the same assertion violation in Emacs 25.2, so this is far from a new problem. On the third hand, this assertion compiles to nothing in a production version, so a production version doesn't crash. Therefore, it sounds like it isn't important enough to fix this on the release branch, unless I'm missing something. Thanks.