From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Crashes in "C-h h"
Date: Wed, 03 Jul 2019 07:28:13 +0300
Message-ID: <83muhvd9nm.fsf@gnu.org>
References: <83y31hes6r.fsf@gnu.org> <mvm1rz9pzn7.fsf@suse.de>
 <83r279epwe.fsf@gnu.org>
 <CAOqdjBfAfLuAUj67LnFx-4tD2g0tUUuA-_Le6scQPWJeD2eo2w@mail.gmail.com>
 <09f72051-d740-9115-c6fd-c4344c749568@cs.ucla.edu>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="102304"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: pipcet@gmail.com, emacs-devel@gnu.org
To: Paul Eggert <eggert@cs.ucla.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 03 06:37:41 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hiX1Y-000QTS-KV
	for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 06:37:40 +0200
Original-Received: from localhost ([::1]:60668 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hiWsh-0000Os-TP
	for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 00:28:31 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55528)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hiWsd-0000Om-M4
 for emacs-devel@gnu.org; Wed, 03 Jul 2019 00:28:28 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34033)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hiWsd-0003T4-4I; Wed, 03 Jul 2019 00:28:27 -0400
Original-Received: from [176.228.60.248] (port=3924 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hiWsc-0001HE-HH; Wed, 03 Jul 2019 00:28:26 -0400
In-reply-to: <09f72051-d740-9115-c6fd-c4344c749568@cs.ucla.edu> (message from
 Paul Eggert on Tue, 2 Jul 2019 19:38:00 -0700)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:238309
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/238309>

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 2 Jul 2019 19:38:00 -0700
> Cc: emacs-devel@gnu.org
> 
> Pip Cet wrote:
> > Is there a problem simply testing FIXNUMP in this place?
> 
> As Eli's revised code suggests, if n is in fixnum range, then instead of 
> (FIXNUMP (x) && XFIXNUM (x) == n) it's typically a bit cleaner (and faster) to 
> write EQ (x, make_fixnum (n)).

It normally shouldn't matter either way, but in that case the
comparison is done in a loop, so the make_fixnum call can be done just
once, outside the loop, which AFAIU makes the loop a tad faster.