From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: pipcet@gmail.com, emacs-devel@gnu.org
Subject: Re: Crashes in "C-h h"
Date: Wed, 03 Jul 2019 07:28:13 +0300 [thread overview]
Message-ID: <83muhvd9nm.fsf@gnu.org> (raw)
In-Reply-To: <09f72051-d740-9115-c6fd-c4344c749568@cs.ucla.edu> (message from Paul Eggert on Tue, 2 Jul 2019 19:38:00 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 2 Jul 2019 19:38:00 -0700
> Cc: emacs-devel@gnu.org
>
> Pip Cet wrote:
> > Is there a problem simply testing FIXNUMP in this place?
>
> As Eli's revised code suggests, if n is in fixnum range, then instead of
> (FIXNUMP (x) && XFIXNUM (x) == n) it's typically a bit cleaner (and faster) to
> write EQ (x, make_fixnum (n)).
It normally shouldn't matter either way, but in that case the
comparison is done in a loop, so the make_fixnum call can be done just
once, outside the loop, which AFAIU makes the loop a tad faster.
next prev parent reply other threads:[~2019-07-03 4:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 14:38 Crashes in "C-h h" Eli Zaretskii
2019-07-01 14:44 ` Lars Ingebrigtsen
2019-07-01 14:57 ` Eli Zaretskii
2019-07-01 15:01 ` Andreas Schwab
2019-07-01 15:27 ` Eli Zaretskii
2019-07-01 15:40 ` Pip Cet
2019-07-01 15:51 ` Pip Cet
2019-07-02 2:31 ` Eli Zaretskii
2019-07-03 2:38 ` Paul Eggert
2019-07-03 4:28 ` Eli Zaretskii [this message]
2019-07-03 21:05 ` Paul Eggert
2019-07-04 2:34 ` Eli Zaretskii
2019-07-04 7:15 ` Paul Eggert
2019-07-04 13:05 ` Eli Zaretskii
2019-07-04 20:58 ` Pip Cet
2019-07-04 23:04 ` Paul Eggert
2019-07-05 7:07 ` Pip Cet
2019-07-05 7:52 ` Eli Zaretskii
2019-07-05 8:17 ` Pip Cet
2019-07-05 8:38 ` Eli Zaretskii
2019-07-06 3:42 ` Paul Eggert
2019-07-06 7:08 ` Eli Zaretskii
2019-07-06 9:12 ` VanL
2019-07-06 14:30 ` Paul Eggert
2019-07-11 13:10 ` [OffTopic] " VanL
2019-07-04 4:50 ` Pip Cet
2019-07-02 2:20 ` Eli Zaretskii
2019-07-01 15:06 ` Robert Pluim
2019-07-01 15:29 ` Eli Zaretskii
2019-07-01 15:47 ` Andreas Schwab
2019-07-02 14:34 ` Martin
2019-07-02 14:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83muhvd9nm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.