From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Date: Sat, 01 Feb 2020 21:28:14 +0200 Message-ID: <83mua2hzu9.fsf@gnu.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="79714"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39373@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 01 20:29:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixyS7-000KWn-Ho for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 20:29:11 +0100 Original-Received: from localhost ([::1]:48946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixyS6-0006nF-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 14:29:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58427) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixyRz-0006mx-48 for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 14:29:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixyRy-00067O-98 for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 14:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixyRy-00067G-6H for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 14:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixyRy-0006O0-3Z for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 14:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158058532024517 (code B ref 39373); Sat, 01 Feb 2020 19:29:02 +0000 Original-Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 19:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:39352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyRb-0006NN-QQ for submit@debbugs.gnu.org; Sat, 01 Feb 2020 14:28:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyRa-0006N9-56 for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 14:28:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixyRU-0005FX-Pt; Sat, 01 Feb 2020 14:28:32 -0500 Original-Received: from [176.228.60.248] (port=2102 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixyRS-0003bK-Ni; Sat, 01 Feb 2020 14:28:32 -0500 In-reply-to: <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 1 Feb 2020 20:24:56 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175567 Archived-At: > From: Mattias Engdegård > Date: Sat, 1 Feb 2020 20:24:56 +0100 > Cc: 39373@debbugs.gnu.org > > It all seems rather fragile to me, and I'd rather add a note about not using add-to-list for lexical variables to its doc string and the manual, and fix all the calls listed above. I tend to agree. Stefan, any comments? > Two patches attached: a doc update, and a replacement of add-to-list in the cases listed above. LGTM, on both counts, but let's hear from Stefan (and others, if someone has an opinion). Thanks.