From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39491: 28.0.50; two bugs in battery-upower Date: Sat, 08 Feb 2020 09:30:54 +0200 Message-ID: <83mu9tedsh.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="114545"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39491@debbugs.gnu.org, rms@gnu.org, Stefan Monnier To: Evgeny Zajcev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 08 08:32:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0Kb6-000Ti0-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 08:32:12 +0100 Original-Received: from localhost ([::1]:38548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0Kb5-0003PC-Dd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 02:32:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0Kax-0003OQ-55 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 02:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0Kaw-0004v3-6V for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 02:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0Kaw-0004ux-3L for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 02:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0Kaw-0000Yw-0Z for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2020 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39491 X-GNU-PR-Package: emacs Original-Received: via spool by 39491-submit@debbugs.gnu.org id=B39491.15811470902122 (code B ref 39491); Sat, 08 Feb 2020 07:32:01 +0000 Original-Received: (at 39491) by debbugs.gnu.org; 8 Feb 2020 07:31:30 +0000 Original-Received: from localhost ([127.0.0.1]:50571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0KaP-0000YA-O7 for submit@debbugs.gnu.org; Sat, 08 Feb 2020 02:31:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0KaN-0000Xx-GQ for 39491@debbugs.gnu.org; Sat, 08 Feb 2020 02:31:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j0KaI-0004oX-2K; Sat, 08 Feb 2020 02:31:22 -0500 Original-Received: from [176.228.60.248] (port=3500 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j0KaA-0006Cm-2e; Sat, 08 Feb 2020 02:31:14 -0500 In-reply-to: (message from Richard Stallman on Fri, 07 Feb 2020 15:14:57 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175773 Archived-At: > From: Richard Stallman > Date: Fri, 07 Feb 2020 15:14:57 -0500 > > > battery-upower crashes on my laptop because there is no BatteryLevel property. > This code > > (cons ?b (cond ((= level 3) "-") > ((= level 4) "!") > (online-p "+") > (t ""))) > > needs to handle nil. I don't know what value it should return for that case. > > However, that function has a design flaw: it reports on just the first > battery in the list. battery-upower-device-list correctly returns a > list with an element for each battery, but battery-upower finds only one > of them (the first one in the list) and ignores the others. > > The old code handle all the batteries and added the energy quantities > so as to report accurately the total power available and overall > fraction of charge. I wrote that code myself, around 10 years ago. > > Please restore the lost functionality. Evgeny, could you please look into fixing this? TIA