From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions Date: Mon, 02 Mar 2020 18:33:05 +0200 Message-ID: <83mu8yyawu.fsf@gnu.org> References: <87mwaq74xg.fsf@fencepost.gnu.org> <87h7z86hs9.fsf@stefankangas.se> <86v9nooxcg.fsf@gmail.com> <87tv38kp33.fsf@fencepost.gnu.org> <83sgisypbd.fsf@gnu.org> <87pndwklz6.fsf@fencepost.gnu.org> <83o8tgyn1k.fsf@gnu.org> <874kv83pg7.fsf@fencepost.gnu.org> <83lfokylpp.fsf@gnu.org> <87r1yb8kbv.fsf@gmail.com> <87wo8340ct.fsf@stefankangas.se> <874kv7ozf9.fsf@fencepost.gnu.org> <87o8tf7xu3.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 02 17:34:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8o1D-000Kvi-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 17:34:11 +0100 Original-Received: from localhost ([::1]:34904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8o1C-0003Gc-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 11:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51773) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8o15-0003G1-TC for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 11:34:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8o14-00024c-Sj for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 11:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j8o14-00023k-Oi for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 11:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j8o14-0001lD-Kq for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2020 11:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Mar 2020 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18336 X-GNU-PR-Package: emacs Original-Received: via spool by 18336-submit@debbugs.gnu.org id=B18336.15831667996713 (code B ref 18336); Mon, 02 Mar 2020 16:34:02 +0000 Original-Received: (at 18336) by debbugs.gnu.org; 2 Mar 2020 16:33:19 +0000 Original-Received: from localhost ([127.0.0.1]:38294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j8o0M-0001kC-PZ for submit@debbugs.gnu.org; Mon, 02 Mar 2020 11:33:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j8o0L-0001jy-7q for 18336@debbugs.gnu.org; Mon, 02 Mar 2020 11:33:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j8o0F-0001Hr-Qj; Mon, 02 Mar 2020 11:33:11 -0500 Original-Received: from [176.228.60.248] (port=4739 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j8o0E-000080-Ot; Mon, 02 Mar 2020 11:33:11 -0500 In-Reply-To: <87o8tf7xu3.fsf@gmail.com> (message from Noam Postavsky on Mon, 02 Mar 2020 07:20:04 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176775 Archived-At: > From: Noam Postavsky > Cc: Stefan Kangas , Eli Zaretskii , 18336@debbugs.gnu.org > Date: Mon, 02 Mar 2020 07:20:04 -0500 > > > and my /tmp file system where I also saw this is > > > > /dev/sda5 on / type ext4 (rw,noatime,discard) > > Aha, this seems to be the key. I ran my initial experiment in ~/tmp, > which is mounted with relatime > > /dev/sda9 on /home type ext4 (rw,relatime,data=ordered) > > When I do the same on /tmp, which is mounted noatime I see the extra > " changed on disk; really edit the buffer?" question on C-x C-s. > > /dev/sda8 on /tmp type ext4 (rw,noatime,data=ordered) This seems to point to the call to lock_file we make in write_region (which is called to save the buffer). lock_file calls verify-visited-file-modtime, which might be affected by the noatime option. But I don't understand how noatime could affect verify-visited-file-modtime since the latter looks at mtime, not atime. Or maybe the time is not the issue here, and the problem is with the check of the file's size that verify-visited-file-modtime performs? Can someone who sees this step with GDB through lock_file and its callees, and see what goes wrong there and why?