all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org
Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions
Date: Mon, 02 Mar 2020 18:33:05 +0200	[thread overview]
Message-ID: <83mu8yyawu.fsf@gnu.org> (raw)
In-Reply-To: <87o8tf7xu3.fsf@gmail.com> (message from Noam Postavsky on Mon, 02 Mar 2020 07:20:04 -0500)

> From: Noam Postavsky <npostavs@gmail.com>
> Cc: Stefan Kangas <stefan@marxist.se>,  Eli Zaretskii <eliz@gnu.org>,  18336@debbugs.gnu.org
> Date: Mon, 02 Mar 2020 07:20:04 -0500
> 
> > and my /tmp file system where I also saw this is
> >
> > /dev/sda5 on / type ext4 (rw,noatime,discard)
> 
> Aha, this seems to be the key.  I ran my initial experiment in ~/tmp,
> which is mounted with relatime
> 
>     /dev/sda9 on /home type ext4 (rw,relatime,data=ordered)
> 
> When I do the same on /tmp, which is mounted noatime I see the extra
> "<file> changed on disk; really edit the buffer?" question on C-x C-s.
> 
>     /dev/sda8 on /tmp type ext4 (rw,noatime,data=ordered)

This seems to point to the call to lock_file we make in write_region
(which is called to save the buffer).  lock_file calls
verify-visited-file-modtime, which might be affected by the noatime
option.  But I don't understand how noatime could affect
verify-visited-file-modtime since the latter looks at mtime, not
atime.

Or maybe the time is not the issue here, and the problem is with the
check of the file's size that verify-visited-file-modtime performs?

Can someone who sees this step with GDB through lock_file and its
callees, and see what goes wrong there and why?





  reply	other threads:[~2020-03-02 16:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  7:44 bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions David Kastrup
2020-03-01  0:27 ` Stefan Kangas
2020-03-01 16:26   ` Noam Postavsky
2020-03-01 16:38     ` David Kastrup
2020-03-01 17:09       ` Eli Zaretskii
2020-03-01 17:45         ` David Kastrup
2020-03-01 17:58           ` Eli Zaretskii
2020-03-01 18:22             ` David Kastrup
2020-03-01 18:27               ` Eli Zaretskii
2020-03-02  4:14                 ` Noam Postavsky
2020-03-02  8:27                   ` Eli Zaretskii
2020-03-02  9:42                     ` David Kastrup
2020-03-02 11:04                       ` Eli Zaretskii
2020-03-02 11:41                         ` David Kastrup
2020-03-02 11:51                           ` Eli Zaretskii
2020-03-02  8:39                   ` Stefan Kangas
2020-03-02  8:55                     ` Eli Zaretskii
2020-03-02  9:04                       ` Stefan Kangas
2020-03-02 11:01                         ` Eli Zaretskii
2020-03-02  9:53                     ` David Kastrup
2020-03-02 12:20                       ` Noam Postavsky
2020-03-02 16:33                         ` Eli Zaretskii [this message]
2020-03-05 14:13                           ` Noam Postavsky
2020-03-05 15:07                             ` David Kastrup
2020-03-05 17:54                               ` Noam Postavsky
2020-03-05 19:31                                 ` Eli Zaretskii
2020-03-22  1:13                                   ` Noam Postavsky
2020-03-22 14:35                                     ` Eli Zaretskii
2020-03-22 15:45                                       ` Noam Postavsky
2020-03-22 17:09                                         ` Eli Zaretskii
2020-03-22 19:46                                           ` Noam Postavsky
2020-03-22 20:16                                             ` Eli Zaretskii
2020-03-23  3:26                                               ` Noam Postavsky
2020-03-05 16:02                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mu8yyawu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=18336@debbugs.gnu.org \
    --cc=dak@gnu.org \
    --cc=npostavs@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.