From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove obsolete fast-lock and lazy-lock libraries Date: Sun, 09 Aug 2020 16:54:59 +0300 Message-ID: <83mu336i18.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7221"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Jeff Norden Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 09 15:55:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4lnh-0001m7-N7 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 15:55:49 +0200 Original-Received: from localhost ([::1]:59526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4lng-0008Bd-PW for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 09:55:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4lnD-0007h5-1w for emacs-devel@gnu.org; Sun, 09 Aug 2020 09:55:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60177) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4lnA-0000fR-TN; Sun, 09 Aug 2020 09:55:16 -0400 Original-Received: from [176.228.60.248] (port=4753 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4ln9-0004HN-KN; Sun, 09 Aug 2020 09:55:16 -0400 In-Reply-To: (message from Jeff Norden on Sat, 08 Aug 2020 23:04:42 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253542 Archived-At: > From: Jeff Norden > Date: Sat, 08 Aug 2020 23:04:42 -0500 > Cc: stefankangas@gmail.com, monnier@iro.umontreal.ca > > A variable name like font-lock-use-jit might be more clear, maybe with > font-lock-support-mode as an obsolete alias, which would now only have a > nil-or-non-nil effect. Perhaps this would be good to do along with > removing {fast,lazy}-lock. If someone has an ancient .emacs that contains > (setq font-lock-support-mode 'fast-lock-mode) > would the best thing be to just use jit-lock-mode instead? If I'm reading > the patch correctly, it would make setting the support-mode to fast-lock > equivalent to setting it to nil. I see no particular reason to rename the variable, just because it currently has only one user (inside the core). It's not like adding other users is unimaginable, and renaming is always a certain shock, however small. > It might make sense to also drop the defcustom status of the support-mode > variable (or its replacement), since jit-lock is the only non-nil option. Likewise here: we have many options that have just 2 values, and they are still defcustom's. In general, such cleanups are IMO only justified if they bring some real advantages, or if the variables are no longer used at all. This is not such a case. Thanks.