From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 44155@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#44155: Print integers as characters
Date: Sun, 25 Oct 2020 19:22:46 +0200 [thread overview]
Message-ID: <83mu0afcex.fsf@gnu.org> (raw)
In-Reply-To: <87d0172yev.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 24 Oct 2020 22:53:44 +0300)
> From: Juri Linkov <juri@linkov.net>
> Date: Sat, 24 Oct 2020 22:53:44 +0300
> Cc: 44155@debbugs.gnu.org
>
> + EMACS_INT c = XFIXNUM (obj);
There's no need to use EMACS_INT, a character code is at most 22 bits,
so it always fits into an 'int'.
> + if (EQ (Vinteger_output_format, Qt) && CHARACTERP (obj) && c < 4194176)
^^^^^^^
Please use MAX_5_BYTE_CHAR here. Or, better yet, CHAR_BYTE8_P.
And, btw, why not allow raw bytes here as well? is there some problem?
> + {
> + printchar ('?', printcharfun);
> +
> + if (escapeflag
> + && (c == ';' || c == '(' || c == ')' || c == '{' || c == '}'
> + || c == '[' || c == ']' || c == '\"' || c == '\'' || c == '\\'))
> + printchar ('\\', printcharfun);
> + print_string (Fchar_to_string (obj), printcharfun);
Why are you using print_string here instead of printchar? IOW, what
is the difference between printing a backslash and printing any other
character, that you can use printchar for the former, but not for the
latter?
> + else if (INTEGERP (Vinteger_output_format)
> + && XFIXNUM (Vinteger_output_format) == 16 && c >= 0)
If you really want to allow Vinteger_output_format to be a bignum, you
cannot use XFIXNUM with it, you need to use integer_to_intmax or
somesuch. Otherwise, you should use FIXNUMP instead of INTEGERP.
> + DEFVAR_LISP ("integer-output-format", Vinteger_output_format,
> + doc: /* The format used to print integers.
> +When 't', print integers as characters.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
But only integers that are small enough, yes?
> +When a number 16, print numbers in hex format.
This immediately begs the question: why cannot the value be 8 or 2?
Thanks.
P.S. This will eventually need a NEWS entry.
next prev parent reply other threads:[~2020-10-25 17:22 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:05 bug#43866: 26.3; italian postfix additions Francesco Potortì
2020-10-08 12:26 ` Eli Zaretskii
2020-10-08 12:34 ` Francesco Potortì
2020-10-08 12:39 ` Robert Pluim
2020-10-08 12:57 ` Eli Zaretskii
2020-10-08 13:54 ` Robert Pluim
2020-10-08 14:24 ` Robert Pluim
2020-10-08 14:32 ` Eli Zaretskii
2020-10-08 13:26 ` Francesco Potortì
2020-10-08 14:00 ` Robert Pluim
2020-10-13 20:07 ` Juri Linkov
2020-10-14 2:31 ` Eli Zaretskii
2020-10-14 8:07 ` Juri Linkov
2020-10-14 15:07 ` Eli Zaretskii
2020-10-14 19:40 ` Juri Linkov
2020-10-15 2:34 ` Eli Zaretskii
2020-10-19 20:45 ` Juri Linkov
2020-10-19 23:12 ` Stefan Kangas
2020-10-20 18:42 ` Juri Linkov
2020-10-20 14:12 ` Eli Zaretskii
2020-10-20 14:47 ` Robert Pluim
2020-10-20 15:50 ` Eli Zaretskii
2020-10-20 18:44 ` Juri Linkov
2020-10-20 19:05 ` Juri Linkov
2020-10-21 8:11 ` Robert Pluim
2020-10-21 14:29 ` Eli Zaretskii
2020-10-21 14:40 ` Robert Pluim
2020-10-21 15:23 ` Eli Zaretskii
2020-10-21 17:30 ` Juri Linkov
2020-10-20 19:56 ` Juri Linkov
2020-10-21 14:02 ` Eli Zaretskii
2020-10-21 17:23 ` Juri Linkov
2020-10-21 18:16 ` Eli Zaretskii
2020-10-21 18:27 ` Juri Linkov
2020-10-21 18:35 ` Eli Zaretskii
2020-10-21 19:39 ` Juri Linkov
2020-10-22 12:59 ` Eli Zaretskii
2020-10-22 20:56 ` bug#44155: Print integers as characters Juri Linkov
2020-10-22 22:39 ` Andreas Schwab
2020-10-23 8:16 ` Juri Linkov
2020-10-23 8:32 ` Juri Linkov
2020-10-24 19:53 ` Juri Linkov
2020-10-25 17:22 ` Eli Zaretskii [this message]
2020-10-25 19:09 ` Juri Linkov
2020-10-25 19:53 ` Eli Zaretskii
2020-10-27 20:08 ` Juri Linkov
2020-10-28 15:51 ` Eli Zaretskii
2020-10-28 19:41 ` Juri Linkov
2020-10-29 14:20 ` Eli Zaretskii
2020-10-29 21:00 ` Juri Linkov
2020-10-30 7:35 ` Eli Zaretskii
2020-10-31 20:11 ` Juri Linkov
2020-10-31 23:27 ` Glenn Morris
2020-11-01 7:58 ` Juri Linkov
2020-11-01 15:13 ` Eli Zaretskii
2020-11-01 18:39 ` Juri Linkov
2020-11-01 18:51 ` Eli Zaretskii
2020-11-01 19:13 ` Juri Linkov
2020-11-01 19:41 ` Eli Zaretskii
2020-11-01 20:16 ` Juri Linkov
2020-11-01 12:03 ` Mattias Engdegård
2020-11-01 18:35 ` Juri Linkov
2020-11-01 20:52 ` Mattias Engdegård
2020-11-02 21:36 ` Juri Linkov
2020-11-02 23:03 ` Mattias Engdegård
2020-11-03 8:30 ` Juri Linkov
2020-11-03 15:24 ` Eli Zaretskii
2020-11-03 18:47 ` Mattias Engdegård
2020-11-03 19:36 ` Eli Zaretskii
2020-11-04 11:03 ` Mattias Engdegård
2020-11-04 15:38 ` Eli Zaretskii
2020-11-04 16:46 ` Mattias Engdegård
2020-11-04 16:58 ` Mattias Engdegård
2020-11-06 13:02 ` Mattias Engdegård
2022-04-30 12:19 ` bug#43866: 26.3; italian postfix additions Lars Ingebrigtsen
2022-04-30 12:29 ` Eli Zaretskii
2022-04-30 14:49 ` Lars Ingebrigtsen
2022-04-30 15:26 ` Eli Zaretskii
2022-04-30 18:49 ` Lars Ingebrigtsen
2022-05-29 13:35 ` Lars Ingebrigtsen
2020-10-15 3:52 ` Richard Stallman
2020-10-14 4:38 ` Richard Stallman
2020-10-14 8:11 ` Juri Linkov
2020-10-14 10:43 ` Robert Pluim
2020-10-15 3:54 ` Richard Stallman
2020-10-14 14:56 ` Eli Zaretskii
2020-10-08 15:23 ` Mattias Engdegård
2020-10-08 15:35 ` Robert Pluim
2020-10-08 16:22 ` Francesco Potortì
2020-10-08 15:42 ` Eli Zaretskii
2020-10-08 16:10 ` Francesco Potortì
2020-10-08 17:18 ` Robert Pluim
2020-10-08 17:28 ` Francesco Potortì
2020-10-08 17:59 ` Mattias Engdegård
2020-10-08 19:55 ` Francesco Potortì
2020-10-09 4:42 ` Lars Ingebrigtsen
2020-10-09 11:26 ` Mattias Engdegård
2020-10-09 11:53 ` Thien-Thi Nguyen
2020-10-09 12:45 ` Robert Pluim
2020-10-09 14:31 ` Eli Zaretskii
2020-10-09 14:48 ` Robert Pluim
2020-10-09 15:04 ` Eli Zaretskii
2020-10-10 20:54 ` Lars Ingebrigtsen
2020-10-12 9:26 ` Robert Pluim
2020-10-09 15:05 ` Mattias Engdegård
2020-10-09 15:08 ` Robert Pluim
2020-10-09 15:28 ` Mattias Engdegård
2020-10-09 15:10 ` Eli Zaretskii
2020-10-09 15:21 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mu0afcex.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44155@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.