From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: night-mode? Date: Sun, 22 Nov 2020 17:16:19 +0200 Message-ID: <83mtz9xvzw.fsf@gnu.org> References: <87zh3awu11.fsf@mail.linkov.net> <87tuth6c30.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 22 16:17:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgr7J-0008Zf-QD for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Nov 2020 16:17:29 +0100 Original-Received: from localhost ([::1]:57768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgr7I-0007yV-T9 for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Nov 2020 10:17:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgr6L-0007Y0-Qt for emacs-devel@gnu.org; Sun, 22 Nov 2020 10:16:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45476) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgr6J-0004Wb-Dm; Sun, 22 Nov 2020 10:16:28 -0500 Original-Received: from [176.228.60.248] (port=4002 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kgr6H-0006co-Oz; Sun, 22 Nov 2020 10:16:26 -0500 In-Reply-To: <87tuth6c30.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 22 Nov 2020 10:40:19 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259615 Archived-At: > From: Juri Linkov > Date: Sun, 22 Nov 2020 10:40:19 +0200 > Cc: emacs-devel@gnu.org > > diff --git a/lisp/startup.el b/lisp/startup.el > index 9f67dfde12..71d640701b 100644 > --- a/lisp/startup.el > +++ b/lisp/startup.el > @@ -834,6 +834,7 @@ tty-handle-args > argval))) > default-frame-alist)) > ((member argi '("-r" "-rv" "-reverse")) > + (setq night-mode t) > (push '(reverse . t) > default-frame-alist)) > ((equal argi "-color") I don't see why we should consider -rv be the sign of "night". Many people use dark backgrounds for reasons that have nothing to do with the time of day, and -rv is not such a sign, either. I think we should ask users who'd want to have a special theme for the night and that routinely use the dark-background colors what would they like to see by night. It isn't enough just to invert the colors, IMO.