From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 20:48:53 +0200 Message-ID: <83mtv0fgbu.fsf@gnu.org> References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 47234@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 19:50:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMxjA-0009ql-O9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 19:50:36 +0100 Original-Received: from localhost ([::1]:52494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxj9-00063H-L6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 14:50:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMxic-000628-Pu for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMxic-0007sZ-IK for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMxic-00027S-FA for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 14:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47234 X-GNU-PR-Package: emacs Original-Received: via spool by 47234-submit@debbugs.gnu.org id=B47234.16160933438070 (code B ref 47234); Thu, 18 Mar 2021 18:50:02 +0000 Original-Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 18:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:48065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxhe-000266-Ee for submit@debbugs.gnu.org; Thu, 18 Mar 2021 14:49:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxhb-00025c-TJ for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 14:49:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33670) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxhV-0007TG-TI; Thu, 18 Mar 2021 14:48:53 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3390 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMxhU-00041f-7O; Thu, 18 Mar 2021 14:48:53 -0400 In-Reply-To: <87y2eko0js.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 18 Mar 2021 19:07:55 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202638 Archived-At: > From: Juri Linkov > Cc: martin rudalics , Eli Zaretskii , 47234@debbugs.gnu.org > Date: Thu, 18 Mar 2021 19:07:55 +0200 > > >>> Is the following close to TRT? > >> > >> If it produces the right result under all of the complications you > >> mentioned, sure. > > > > Thanks, it does AFAICT. Hopefully Juri can confirm/deny for certain. > > (For example, I don't know when one would pick Ftab_bar_height over the > > frame property tab-bar-lines - maybe the latter can be used > > unconditionally?) > > I agree with Martin that `tab-bar-height' should return a meaningful value > on --without-x builds too. How do you propose to do that? The design and implementation of the code in tab-bar-height was stolen from the tool bar, and that was written for GUI frames. The text-mode tab bar has an entirely different design and implementation, similar to the text-mode menu bar. There's almost nothing in common between these two. > Please note this should be fixed on the release branch in Emacs 27.2 > because the change in commit 6c5ddf0e0b was recently made in emacs-27. Why does it have to be done in Emacs 27.2? Please be aware that Emacs 27.2 is all but released at this point. > I wonder why only tab-bar-height was added to frame-inner-height, > why not menu-bar-height as well? Moreover, such function as > menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? Maybe tab-bar-height is not needed in this case, either. We could instead modify the code that attempts to call it.