* Warning compiling image-dired.el
@ 2021-11-04 7:59 Eli Zaretskii
2021-11-04 18:52 ` Stefan Kangas
0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2021-11-04 7:59 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
ELC image-dired.elc
In end of data:
image-dired.el:2913:14: Warning: the function `image-mode-fit' is not known to be defined.
The call to image-mode-fit was introduced in commit 73a6c8f9. I don't
see that function anywhere, and there are no comments near its call to
explain what is this call supposed to achieve. (Why should we try
"fitting" an image in a command that's supposed to display the image
in its full size?)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Warning compiling image-dired.el
2021-11-04 7:59 Warning compiling image-dired.el Eli Zaretskii
@ 2021-11-04 18:52 ` Stefan Kangas
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2021-11-04 18:52 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> ELC image-dired.elc
>
> In end of data:
> image-dired.el:2913:14: Warning: the function `image-mode-fit' is not known to be defined.
Thanks, now fixed on master.
> The call to image-mode-fit was introduced in commit 73a6c8f9. I don't
> see that function anywhere, and there are no comments near its call to
> explain what is this call supposed to achieve. (Why should we try
> "fitting" an image in a command that's supposed to display the image
> in its full size?)
It should have been `image-transform-original'.
(I had actually added it to the "obsolete" declaration of that function,
but had missed to update the call in the function body.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-04 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 7:59 Warning compiling image-dired.el Eli Zaretskii
2021-11-04 18:52 ` Stefan Kangas
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.