From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51734: 29.0.50; got slow Date: Thu, 11 Nov 2021 22:36:33 +0200 Message-ID: <83mtmazay6.fsf@gnu.org> References: <83a6ic41g3.fsf@gnu.org> <83pmr715c5.fsf@gnu.org> <83ilwy22y1.fsf@gnu.org> <090472b2-4f54-2f31-cb9e-30956cbcbb31@cornell.edu> <83tugizg8v.fsf@gnu.org> <6ef97cf3-6f8e-40f7-aef9-cbd2755756cc@cornell.edu> <83o86qzbpg.fsf@gnu.org> <843f06f4-3666-1fd9-cad9-860b475b2938@cornell.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yamaoka@jpl.org, 51734@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 21:37:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlGos-000AAX-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 21:37:15 +0100 Original-Received: from localhost ([::1]:38864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlGor-0000jX-ET for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 15:37:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlGoh-0000ij-03 for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 15:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlGog-0007Ir-Nb for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 15:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlGog-0003QB-Ef for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 15:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51734 X-GNU-PR-Package: emacs Original-Received: via spool by 51734-submit@debbugs.gnu.org id=B51734.163666301013133 (code B ref 51734); Thu, 11 Nov 2021 20:37:02 +0000 Original-Received: (at 51734) by debbugs.gnu.org; 11 Nov 2021 20:36:50 +0000 Original-Received: from localhost ([127.0.0.1]:42418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlGoU-0003Pk-Cq for submit@debbugs.gnu.org; Thu, 11 Nov 2021 15:36:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlGoS-0003PX-Q8 for 51734@debbugs.gnu.org; Thu, 11 Nov 2021 15:36:49 -0500 Original-Received: from [2001:470:142:3::e] (port=43116 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlGoL-0007Gp-3w; Thu, 11 Nov 2021 15:36:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ddsjTYO/SAz1pXvA1yUKpdrSJ/CatuFWl8qb0IWiDSQ=; b=pD9SE2VHCUpk nuae9GP9GAN7rT15GsDLrP8j2Mybw+tlz2QcxjuHOPSOA6HOirD51tIzg5MJlyNiD1W/q1mYwModB iMj6b2wwELK5mjPPdR9M72bwcK9r8THn02s9u/v3T830/tByQn7YyqLxadrhEaQCmlx8fml/5fK1S IXPWZ7ooXupj8e5JEsSgknu1Ixvjl7T4w8pIvGLS+ulgi0iwyurJMi6K+zhNjVW43KXnZpCegPh2s FMo4vCaPBbaPqdrMi5gofzXr9uz0oA/1RV0+nkaBKliDxUm1j6NNGaMiSAYAl7LKJ+oLJ/KCNEv/y 7YH2d/gg4YMXYr40TdAsUg==; Original-Received: from [87.69.77.57] (port=2748 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlGoK-000248-KB; Thu, 11 Nov 2021 15:36:41 -0500 In-Reply-To: <843f06f4-3666-1fd9-cad9-860b475b2938@cornell.edu> (message from Ken Brown on Thu, 11 Nov 2021 15:30:51 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219687 Archived-At: > Date: Thu, 11 Nov 2021 15:30:51 -0500 > Cc: yamaoka@jpl.org, 51734@debbugs.gnu.org > From: Ken Brown > > >> Here's a patch that does that. Does it look OK? > > > > ENOPATCH > > Sorry. > > From abe88311b7e47c1cdac2b2405d43ff19826fd911 Mon Sep 17 00:00:00 2001 > From: Ken Brown > Date: Thu, 11 Nov 2021 15:09:24 -0500 > Subject: [PATCH] Don't start both timerfd and alarms on Cygwin > > * src/atimer.c (set_alarm) [CYGWIN]: Don't start both timerfd and > alarms; this causes a slowdown. (Bug#51734) > --- > src/atimer.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/atimer.c b/src/atimer.c > index 490c21bff1..9bde9c2446 100644 > --- a/src/atimer.c > +++ b/src/atimer.c > @@ -316,6 +316,13 @@ set_alarm (void) > exit = true; > } > # endif > + > +# ifdef CYGWIN > + /* Don't start both timerfd and alarms on Cygwin; this > + causes a slowdown (bug#51734). */ > + if (exit) > + return; > +# endif > if (alarm_timer_ok > && timer_settime (alarm_timer, TIMER_ABSTIME, &ispec, 0) == 0) > exit = true; > -- LGTM, thanks. It would be good to understand why starting alarms causes slowdown on Cygwin, though.