From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: yamaoka@jpl.org, 51734@debbugs.gnu.org
Subject: bug#51734: 29.0.50; got slow
Date: Thu, 11 Nov 2021 22:36:33 +0200 [thread overview]
Message-ID: <83mtmazay6.fsf@gnu.org> (raw)
In-Reply-To: <843f06f4-3666-1fd9-cad9-860b475b2938@cornell.edu> (message from Ken Brown on Thu, 11 Nov 2021 15:30:51 -0500)
> Date: Thu, 11 Nov 2021 15:30:51 -0500
> Cc: yamaoka@jpl.org, 51734@debbugs.gnu.org
> From: Ken Brown <kbrown@cornell.edu>
>
> >> Here's a patch that does that. Does it look OK?
> >
> > ENOPATCH
>
> Sorry.
>
> From abe88311b7e47c1cdac2b2405d43ff19826fd911 Mon Sep 17 00:00:00 2001
> From: Ken Brown <kbrown@cornell.edu>
> Date: Thu, 11 Nov 2021 15:09:24 -0500
> Subject: [PATCH] Don't start both timerfd and alarms on Cygwin
>
> * src/atimer.c (set_alarm) [CYGWIN]: Don't start both timerfd and
> alarms; this causes a slowdown. (Bug#51734)
> ---
> src/atimer.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/atimer.c b/src/atimer.c
> index 490c21bff1..9bde9c2446 100644
> --- a/src/atimer.c
> +++ b/src/atimer.c
> @@ -316,6 +316,13 @@ set_alarm (void)
> exit = true;
> }
> # endif
> +
> +# ifdef CYGWIN
> + /* Don't start both timerfd and alarms on Cygwin; this
> + causes a slowdown (bug#51734). */
> + if (exit)
> + return;
> +# endif
> if (alarm_timer_ok
> && timer_settime (alarm_timer, TIMER_ABSTIME, &ispec, 0) == 0)
> exit = true;
> --
LGTM, thanks. It would be good to understand why starting alarms
causes slowdown on Cygwin, though.
next prev parent reply other threads:[~2021-11-11 20:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 0:36 bug#51734: 29.0.50; got slow Katsumi Yamaoka
2021-11-10 12:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 14:08 ` Eli Zaretskii
2021-11-10 12:53 ` Eli Zaretskii
2021-11-11 2:43 ` Katsumi Yamaoka
2021-11-11 8:09 ` Eli Zaretskii
2021-11-11 12:02 ` Katsumi Yamaoka
2021-11-11 14:15 ` Eli Zaretskii
2021-11-11 18:11 ` Ken Brown
2021-11-11 18:33 ` Ken Brown
2021-11-11 18:42 ` Eli Zaretskii
2021-11-11 19:28 ` Ken Brown
2021-11-11 20:17 ` Ken Brown
2021-11-11 20:20 ` Eli Zaretskii
2021-11-11 20:30 ` Ken Brown
2021-11-11 20:36 ` Eli Zaretskii [this message]
2021-11-11 23:45 ` Katsumi Yamaoka
2021-11-12 18:22 ` Ken Brown
2021-11-12 19:26 ` Eli Zaretskii
2021-11-12 20:06 ` Ken Brown
2021-11-14 1:13 ` Lars Ingebrigtsen
2021-11-14 15:42 ` Ken Brown
2021-11-14 17:58 ` Lars Ingebrigtsen
2021-11-14 19:11 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mtmazay6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51734@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.