From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56323: 29.0.50; [v2] Add new customisable phonetic Tamil input method Date: Sat, 02 Jul 2022 09:58:17 +0300 Message-ID: <83mtdsc86u.fsf@gnu.org> References: <87pmiqe4da.fsf@gmail.com> <878rpdq99n.fsf@gmail.com> <83fsjldl2b.fsf@gnu.org> <87tu81osgp.fsf@gmail.com> <83czepdj0z.fsf@gnu.org> <87pmioq51w.fsf@gmail.com> <831qv4erwf.fsf@gnu.org> <87r134aiwd.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56323@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 02 08:59:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7X5x-0008ph-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 08:59:09 +0200 Original-Received: from localhost ([::1]:43176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7X5w-0001SR-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 02:59:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7X5q-0001Qj-2c for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 02:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7X5p-0006XW-Qk for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 02:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7X5p-00044m-Qe for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 02:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2022 06:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56323-submit@debbugs.gnu.org id=B56323.165674512515646 (code B ref 56323); Sat, 02 Jul 2022 06:59:01 +0000 Original-Received: (at 56323) by debbugs.gnu.org; 2 Jul 2022 06:58:45 +0000 Original-Received: from localhost ([127.0.0.1]:39585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7X5X-00044G-LT for submit@debbugs.gnu.org; Sat, 02 Jul 2022 02:58:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7X5H-00043i-4Y for 56323@debbugs.gnu.org; Sat, 02 Jul 2022 02:58:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7X5A-0006Ut-Pw; Sat, 02 Jul 2022 02:58:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ePmQoM0YXQFDUy97XzXleq15AesfTZlNz+X4s6Y9K7Q=; b=P8RsqTXJltkS LDjE4uMVLVMbzQLKlaUXLG17gxflJ7jJ4UTTDCgHYaeeNRNJqaBONaZlPUByAcmB4vFiwuQ8kXkPR qeUY7bh9ardeq9Oj204JQJZOWTiFPvEQdyGrDbHsm4Zh5Qfj5ponl2nk65B0MOumQkaEPQhnerGjP YiFYv2ISDnkufIg6/6irozdEJBVCUJxX8ug+Tfwf8KajjKUipwklk7CCHGVLNsVW3N9uGvtHg3ojv Qh3pe2Vz3dHshzJwUD81pwl5MhY3bfcqhiUSWBCiTpI6kglixU0f11o4dzJrQiH2jbNJoiLPBOamT P9G+/37gO+hF4NxQnae6oA==; Original-Received: from [87.69.77.57] (port=3584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7X5A-0002cl-8f; Sat, 02 Jul 2022 02:58:20 -0400 In-Reply-To: <87r134aiwd.fsf@gmail.com> (message from Visuwesh on Fri, 01 Jul 2022 22:07:38 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235852 Archived-At: > From: Visuwesh > Cc: 56323@debbugs.gnu.org > Date: Fri, 01 Jul 2022 22:07:38 +0530 > > >> BTW, do you have any other code/documentation review? And what about > >> the patch I posted in https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-06/msg02256.html? > >> No rush but I would like to know if it can go in since it only addresses > >> fallouts from the previous bug in this area. Thanks. > > > > It sounded to me like you are still working on the code, so I didn't > > see a need to review it. If you have specific parts that you'd like > > me to review nonetheless, please tell which parts are those. > > Thanks. The patch I posted in > https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-06/msg02256.html > is done, and can be pushed to master if you see no problems. I installed it, thanks. > Also, I would like to know if there's a better to write the :set > function for the defcustoms tamil-vowel-translation, > tamil-consonant-translation, tamil-misc-translation, tamil-native-digits > without the boundp check chain below, > > (defun tamil--set-variable (sym val) > (set-default sym val) > (when (and (boundp 'tamil-vowel-translation) > (boundp 'tamil-consonant-translation) > (boundp 'tamil-misc-translation) > (boundp 'tamil-native-digits)) > (tamil--update-quail-rules))) Why do you need a single function for all of them? Would a separate setter function for each defcustom do the job? I also don't understand the need for the boundp tests -- the function will live on the same indian.el file as the defcustoms, so if the function is defined, the defcustoms are also bound, no? > I'm also doubtful about the current group being used for these > defcustoms. Should I go ahead and make a new 'tamil' group and make it > a subgroup of leim or i18n? It's okay to have a separate group, but what would be the subject of this group? If it's just about input methods, the name had better reflected that, and just "tamil" is too general for that. > And is the prefix tamil- okay or should I change it to something > else? I see no problem with 'tamil-'. > Finally, I'm unsure if "List of input sequences to translate to ..." is > clear. I think it sounds a mouthful and there should be a better way to > put it. I think "translation rules" is quite nice but I'm afraid that > it is too Quail specific and might not be well understood. I have no problem with that wording, but I wonder whether we should have these defcustoms in the first place. What are the chances that some user will want to change the sequences, and why would they want that? P.S. Please in the future don't modify the Subject of the messages in the same bug report: that makes it harder to find related messages at least when using Rmail.