From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PROPOSAL: New function ffap-ip-at-point Date: Fri, 22 Jul 2022 18:01:55 +0300 Message-ID: <83mtd1jin0.fsf@gnu.org> References: <87r12d5xhv.fsf@gmx.com> <83czdxl7gw.fsf@gnu.org> <87fsit5hh7.fsf@gmx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, rpluim@gmail.com To: =?utf-8?Q?I=C3=B1igo?= Serna Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 22 17:05:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEuDc-00067d-1g for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jul 2022 17:05:32 +0200 Original-Received: from localhost ([::1]:38036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEuDa-0002Ef-Ud for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jul 2022 11:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuAD-0005DM-9S for emacs-devel@gnu.org; Fri, 22 Jul 2022 11:02:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuAC-0000Ey-SH; Fri, 22 Jul 2022 11:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=02lNeBw1goWJmczPO8rKRxbyWdkk8IRNLT/8K0kEErM=; b=qE/Nbuushr5Kq1c3CqK7 09rew1plZ+AUfn/G+FTXZ58YgQTVbfGS4VBfgczygo396lX1uN9LUPh9KdsmmCkSqCqGpgqGp+voi DBp5NrZNBB0zKZaCWmV+wOKgdDc6r9bQmBn5IKoC4ADWmvpgZ87KptP72rJXKZJLkhk0pADyYoHhH NBWIllF1+BelphPxauJBdzl/W9rT6cJXaTxZmXnbJieOzXGWiVu265U5ZXHu5kA50u+T90e712Qwd Ti0vwlCHtrqxdBTvUOj8gpPGLHQYM6HAmGxlJ1x53M1FTegbMTPkt6yMnLOmALH8OnNKmTf4dUm/X zJELAVzmR/1jFA==; Original-Received: from [87.69.77.57] (port=4956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuAC-0002r3-5F; Fri, 22 Jul 2022 11:02:00 -0400 In-Reply-To: <87fsit5hh7.fsf@gmx.com> (message from =?utf-8?Q?I=C3=B1igo?= Serna on Fri, 22 Jul 2022 16:46:44 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292446 Archived-At: > From: Iñigo Serna > Cc: Eli Zaretskii , Robert Pluim > Date: Fri, 22 Jul 2022 16:46:44 +0200 > > Thanks Robert and Eli for your comments and suggestions. And thank you for working on this in the first place. > +--- > +** New functions 'ffap-ipv4-at-point', 'ffap-ipv4-p' > +'ffap-ipv4-at-point' return an IPv4 address if it is found at point, ^^^^^^ "returns" > +or nil. 'ffap-ipv4-p' check for a valid IPv4 address. ^^^^^ "checks" Other than that, LGTM.