From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v2] Font lock long Git commit summary lines
Date: Mon, 05 Sep 2022 21:23:47 +0300 [thread overview]
Message-ID: <83mtbdk7d8.fsf@gnu.org> (raw)
In-Reply-To: <87sfl5zo1o.fsf@melete.silentflame.com> (message from Sean Whitton on Mon, 05 Sep 2022 11:14:27 -0700)
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Mon, 05 Sep 2022 11:14:27 -0700
>
> >> +(defun vc-git--log-edit-summary-check (limit)
> >> + (and (re-search-forward "^Summary: " limit t)
> >> + (when-let ((regex
> >> + (cond ((and vc-git-log-edit-summary-max
> >> + vc-git-log-edit-summary-target)
> >
> > Should this test using numberp?
> >
> >> + (vc-git-log-edit-summary-max
> >> + (format ".\\{,%d\\}\\(?2:.*\\)"
> >> + vc-git-log-edit-summary-max))
> >> + (vc-git-log-edit-summary-target
> >> + (format ".\\{,%d\\}\\(.*\\)"
> >> + vc-git-log-edit-summary-target)))))
> >
> > Likewise here.
>
> I put calls to natnump in, but I'm not sure about it. Is it really most
> useful to silently fail to highlight the characters if somehow something
> other than a number has ended up in the variables? I'm new to working
> with font lock so would be grateful for more input.
In similar cases we document this, something like
... any other value is treated as nil.
This is IMO less fragile in the face of users doing silly things with
the value.
Thanks.
next prev parent reply other threads:[~2022-09-05 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 17:03 [PATCH] * vc-git.el (vc-git-log-edit-mode): Font lock long summary lines Sean Whitton
2022-09-04 10:50 ` Lars Ingebrigtsen
2022-09-04 17:27 ` Sean Whitton
2022-09-04 17:42 ` Protesilaos Stavrou
2022-09-04 18:36 ` Matthias Meulien
2022-09-04 18:41 ` Philip Kaludercic
2022-09-04 22:06 ` Sean Whitton
2022-09-04 23:22 ` [PATCH v2] Font lock long Git commit " Sean Whitton
2022-09-05 11:12 ` Lars Ingebrigtsen
2022-09-05 12:07 ` Eli Zaretskii
2022-09-05 18:14 ` Sean Whitton
2022-09-05 18:23 ` Eli Zaretskii [this message]
2022-09-06 0:39 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mtbdk7d8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.