From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Tue, 11 Oct 2022 09:37:38 +0300 Message-ID: <83mta2g91p.fsf@gnu.org> References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> <838rlohzeo.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 58158@debbugs.gnu.org, monnier@iro.umontreal.ca To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 11 08:38:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi8uS-00057t-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 08:38:37 +0200 Original-Received: from localhost ([::1]:36176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oi8uR-0005oY-Qv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 02:38:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi8tu-0005oO-Tb for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 02:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oi8tu-0002PL-FV for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 02:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oi8tu-0006fc-7A for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2022 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58158 X-GNU-PR-Package: emacs Original-Received: via spool by 58158-submit@debbugs.gnu.org id=B58158.166547025925611 (code B ref 58158); Tue, 11 Oct 2022 06:38:02 +0000 Original-Received: (at 58158) by debbugs.gnu.org; 11 Oct 2022 06:37:39 +0000 Original-Received: from localhost ([127.0.0.1]:50674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi8tW-0006f1-Um for submit@debbugs.gnu.org; Tue, 11 Oct 2022 02:37:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi8tU-0006em-HV for 58158@debbugs.gnu.org; Tue, 11 Oct 2022 02:37:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi8tO-0002NE-Ia; Tue, 11 Oct 2022 02:37:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DQIqHeBUjpgCC4mRKsjj2Hm+KYWl2QHtkDyCaX7iX0E=; b=dUVpeFRUgVhX +Dnhy4cJh37aoXLVDyRgaUP5q0doSlvzagHcLeV4XEncb3/2F5umkDykn35KGFI/jtz3Xi5nn/WYO OkjplbA2odQ6IT3PuH30xWeS+n4Ip20WkfThn88Zvw47JYI0XFsQXDSFDZHNpLTHLXv90z1nn4l0I TJ2IUyYu98Ltav242EsB4D80JazPXuM1yMr8nV1Dw3CzdO7HiBcsXku9T45oWcWTcoDtsCF/YlfIi YyjzEw7pMbbWYE4WsO7Bq4D6tSQ6e8U0Gx/tOLHYcAAoXp/dbOQWsmdvrI3kcaWGOiDmw/mJASx0+ 5A0P1FddUV4M/8QwwMhWQA==; Original-Received: from [87.69.77.57] (port=4960 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi8tO-0005bS-1i; Tue, 11 Oct 2022 02:37:30 -0400 In-Reply-To: (message from Dmitry Gutov on Tue, 11 Oct 2022 05:12:11 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245090 Archived-At: > Date: Tue, 11 Oct 2022 05:12:11 +0300 > Cc: gerd.moellmann@gmail.com, 58158@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Dmitry Gutov > > What is a "subset of matches"? Feel free to suggest a less vague description. The idea is that the list in Xref buffer doesn't show all the references to the identifier, making renaming infeasible. > Perhaps we should make the error very specific, like "you can't replace > inside xref-find-definitions results". Since that is going to be the > exception in like 99.9% of the cases. That'd be my preference, but what are those 0.1% of cases where the Xref buffer produced by other commands could fit? More generally, what exactly does xref.el test to produce the error message, and how to describe that in user-level terms? > It's possible for other backend commands (such as find-references) to > return unsuitable xref values in third-party backends, or for other code > to use xref-show-xrefs with such, but those will be really very rare, if > happen at all. You are saying that 'r' is only useful after M-?, is that right? The manual says so, but the manual doesn't have to say "the whole truth". The doc string should.