From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sat, 29 Oct 2022 18:48:35 +0300 Message-ID: <83mt9ehbqk.fsf@gnu.org> References: <6549.1667057093@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 29 17:49:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooo5N-0002Bg-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Oct 2022 17:49:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooo51-0004zu-W6; Sat, 29 Oct 2022 11:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooo50-0004zW-03 for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooo4z-0003ar-P7 for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooo4z-0006qM-Ki for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 15:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166705853126287 (code B ref 58721); Sat, 29 Oct 2022 15:49:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 29 Oct 2022 15:48:51 +0000 Original-Received: from localhost ([127.0.0.1]:36405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooo4o-0006pv-Rq for submit@debbugs.gnu.org; Sat, 29 Oct 2022 11:48:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooo4l-0006pd-F6 for 58721@debbugs.gnu.org; Sat, 29 Oct 2022 11:48:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooo4g-0003ZT-71; Sat, 29 Oct 2022 11:48:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zHxrGBeFa3IIsYy2gLx/8LwUy4eR6b96COtkNOLIe0w=; b=PlxtgWY30fph mJf9ZuFkxHOHvn+iw1wiWlMstFItMGdSPwfbHZCsz2Zzdm7XES0gnSCgTirf0bobcXeUXD3rLJ/2W IuTi/w7sFLfqpx85x9fNXt2+Di/G4106MYhqi5Q1ljd1ND5fOV2nNamQa1rlVTJBIOPpQvmINbKxk V5p+ptBqDeGr0giPQZPBjuXQFGJl/KT8r8anBipD1tfb5W2EuiBBZ7hGGDRnM9eqC88kfGdFTRk/J NjaWbFd+axYEeyUlV4LJaxHEc1aDF2fDOt70GtZ5jhrOfOcy9o9EJQw1l/z/fKARWZVAA0Nmw9hh4 t4RIqOj6Z1p8lkIf0kvvyg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooo4f-0001by-J4; Sat, 29 Oct 2022 11:48:41 -0400 In-Reply-To: <6549.1667057093@alto> (message from Mike Kupfer on Sat, 29 Oct 2022 08:24:53 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246544 Archived-At: > From: Mike Kupfer > Date: Sat, 29 Oct 2022 08:24:53 -0700 > > I played with this some more this morning, this time on Emacs 29. It > looks like rename-file should have called copy-directory as > > copy-directory("/tmp/emacs-git" > "/home/kupfer/.local/share/Trash/files/emacs-gitH0lx1e/" t nil t) I don't think we can change how rename-file behaves when the argument is a directory. Any changes we need to make must be in move-file-to-trash, not in primitives it calls. Thanks.