From: Eli Zaretskii <eliz@gnu.org>
To: Laurence Warne <laurencewarne@gmail.com>
Cc: luangruo@yahoo.com, michael.albinus@gmx.de, 59407@debbugs.gnu.org
Subject: bug#59407: [PATCH] Add Colors to proced
Date: Mon, 21 Nov 2022 16:28:06 +0200 [thread overview]
Message-ID: <83mt8k2xhl.fsf@gnu.org> (raw)
In-Reply-To: <CAE2oLqjKW8tnDvBmw0ficeyFN97f+jahs0TQoy9W+yFkOjEaYw@mail.gmail.com> (message from Laurence Warne on Mon, 21 Nov 2022 09:07:59 +0000)
> From: Laurence Warne <laurencewarne@gmail.com>
> Date: Mon, 21 Nov 2022 09:07:59 +0000
> Cc: Po Lu <luangruo@yahoo.com>, 59407@debbugs.gnu.org,
> Michael Albinus <michael.albinus@gmx.de>
>
> Thanks. Please be sure to test the new faces with the following Emacs
> configurations:
>
> . GUI frames with dark background
> . GUI frames with light background
> . TTY frames with dark and light backgrounds and with:
> - 8 colors
> - 16 colors
>
> Do you know if there's an easy way I can test the faces on 8/16 colour terminals?
For 8 colors, invoke Emacs with "-nw --color".
For 16 colors, try --color=16, and if it doesn't work, try configuring xterm
for 16 colors, then invoke Emacs with -nw.
> (proced-run-status-code, proced-executable. proced-memory-default)
> (proced-memory-mb, proced-pgrp): New faces.
>
> Minor, but do you mean to add a closing paren at the end of each line?
Yes. You can use the command "C-x 4 a" to format the log entries, it will
do this automatically if auto-fill is turned on.
> I saw this format in the commit log:
> (proced-run-status-code, proced-executable. proced-memory-default,
> proced-memory-mb, proced-pgrp): New faces.
This is wrong.
> This should probably be specified as percentage of total memory. Or maybe
> there should be a separate defcustom for the percentage, and the condition
> should use both. Just a single absolute threshold seems to cover only some
> reasons for highlighting processes with large memory footprint.
>
> I was thinking highlighting based on percentage memory would be more suited to the "mem" process
> attribute (granted though this is not implemented). Though in hindsight a global threshold may not make
> sense if you're connecting to remote systems with varying amounts of RAM. Perhaps the two thresholds
> could mark a percentage, say 10% and 50% of total memory?
Something like that, yes.
Thanks.
next prev parent reply other threads:[~2022-11-21 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 10:26 bug#59407: [PATCH] Add Colors to proced Laurence Warne
2022-11-20 10:48 ` Eli Zaretskii
2022-11-20 12:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-20 14:40 ` Eli Zaretskii
2022-11-21 9:07 ` Laurence Warne
2022-11-21 10:32 ` Michael Albinus
2022-11-21 14:28 ` Eli Zaretskii [this message]
2022-11-25 9:34 ` Laurence Warne
2022-11-25 11:30 ` Michael Albinus
2022-11-25 15:07 ` Eli Zaretskii
2022-11-25 15:19 ` Michael Albinus
2022-11-26 9:41 ` Laurence Warne
2022-11-27 16:04 ` Michael Albinus
2022-11-29 14:02 ` Laurence Warne
2022-12-01 18:17 ` Eli Zaretskii
2022-12-01 21:14 ` Laurence Warne
2022-11-26 12:47 ` Eli Zaretskii
2022-11-20 14:14 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt8k2xhl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59407@debbugs.gnu.org \
--cc=laurencewarne@gmail.com \
--cc=luangruo@yahoo.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.