From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Wed, 30 Nov 2022 05:42:03 +0200 Message-ID: <83mt89kt10.fsf@gnu.org> References: <83edxfds7s.fsf@gnu.org> <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> <83k076dd7d.fsf@gnu.org> <83czcyd8jf.fsf@gnu.org> <83a682d66r.fsf@gnu.org> <837d36ceno.fsf@gnu.org> <37dd2827f54f8bbda5e3@heytings.org> <735c1d5b-0d64-a8e1-3aaa-91fc0248abd3@yandex.ru> <97049541-f5b4-ed3b-b8de-7c0bdc86f0f5@yandex.ru> <6e305c9b-7702-133a-3347-f64db05ade3f@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 04:43:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0E0X-0001f3-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 04:43:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0E0H-0005Eh-Aw; Tue, 29 Nov 2022 22:43:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0E09-0005ES-3F for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 22:43:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0Dzz-0005CT-20 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 22:43:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0Dzy-0000kB-2X for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 22:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 03:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16697797462852 (code B ref 56682); Wed, 30 Nov 2022 03:43:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Nov 2022 03:42:26 +0000 Original-Received: from localhost ([127.0.0.1]:58261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0DzO-0000jw-4v for submit@debbugs.gnu.org; Tue, 29 Nov 2022 22:42:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0DzL-0000jq-5P for 56682@debbugs.gnu.org; Tue, 29 Nov 2022 22:42:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0DzE-00059E-O2; Tue, 29 Nov 2022 22:42:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8gGWqgQzEjspW+UiJ5wXyimuVvkdFpyCoCnAOjqhQVQ=; b=H4ao19wqIcS8 X05N8/JwhxmjgpUEY3ey3S0F6Ihr30sSKrmNcYpQcQPwx23UIf0wOb5M2mi1fcdY9usWNowJd/yA4 hfKz8F4yYXbs1gJgVTH1x9n4syGTul9H7kuVRK1eyCeEW5z4xv3fFxMfYO1ub5vvX62ZCk8XmB65h NEqd2Ijzskdp9YqT0J4Wx6Jxh3le78+Tt2RySlGSjneekNqGIJ1wvfmHBNFFOrPWgP4BAVxY6mFIP KearUe/mKQlKlVISMPSs8Q4HcXWZiGJrF986b7kOsNJoGOfmzAK2goQsGiylM+QPnlS9l8GbDnZ+v YVhY41joG1ODObPBVRtvUQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0DzD-0002Jc-JC; Tue, 29 Nov 2022 22:42:16 -0500 In-Reply-To: (message from Gregory Heytings on Wed, 30 Nov 2022 00:15:39 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249466 Archived-At: > Date: Wed, 30 Nov 2022 00:15:39 +0000 > From: Gregory Heytings > cc: 56682@debbugs.gnu.org, Eli Zaretskii , > Stefan Monnier > > > >> The result will be that the benchmark will report ~30ms both near BOB > >> and near EOB. So the long-lines-threshold thingy adds a regression > >> here. > > > > It's not a regression, it's the price we agreed to pay to detect whether > > the buffer contains long lines. That detection happens dynamically, to > > catch cases when long lines are inserted in a buffer. > > > > After looking at this closely, it turns out that the change in 1c837c42c2 > doesn't do what it was meant to do. Sigh... Dmitry, can you confirm that > the following change fixes this? I think this is just one aspect of the issue. The loop under this condition "punishes" large buffers with no long lines because we search the entire buffer top to bottom. To make this scale better, I think we should only search in some predefined vicinity of the window, perhaps the same region to which we narrow the buffer when we do detect long lines. We can then repeat the search if point moves far away from its last value. There's no need to search the whole buffer, that will cause delays in very large buffers for no good reason. We've talked about this a few months ago, and you said fixing this was part of your todo. I think now is the time.