From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60983: 29.0.60; Tree-sitter user-level control Date: Sat, 21 Jan 2023 14:36:00 +0200 Message-ID: <83mt6ckqts.fsf@gnu.org> References: <83tu0kkuqo.fsf@gnu.org> <87tu0k3y6t.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60983@debbugs.gnu.org, casouri@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 13:37:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJD7b-0008To-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 13:37:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJD7I-0001Xa-HI; Sat, 21 Jan 2023 07:37:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJD7H-0001Wz-B6 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJD7G-0000OC-Iu for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJD7G-0005TZ-5i for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60983 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, casouri@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.167430456320975 (code B ref -1); Sat, 21 Jan 2023 12:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jan 2023 12:36:03 +0000 Original-Received: from localhost ([127.0.0.1]:48240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJD6I-0005SE-MH for submit@debbugs.gnu.org; Sat, 21 Jan 2023 07:36:02 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:43958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJD6G-0005Rl-6J for submit@debbugs.gnu.org; Sat, 21 Jan 2023 07:36:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJD6F-0001Ex-76 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 07:35:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJD6E-0006yN-AT; Sat, 21 Jan 2023 07:35:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gLJ+pTo0234H04FQUggl3i4WKozKEn3VT5e252AM3ng=; b=ixP7qSvv/1Ya be2axK7SKSbQBOaByYFlvc1liPKlqDIylAo/5vJwa3LwUuQggDE36PCUT8CctwyWUNfSO3egClB4U EW77/HPNjmIkc2NYghVosjrM9z1AAYXURSoZM7GsnAoR7Jz49GsITPwFECkmZM2DwcUluB6n2RF+7 R/2aJNBhNqNz81j13E4x1vNMLYI3Gp6BxEu7rvC1knlF+DtklrUhXI4N3ioyLlM59gd40X1poBWFE ktBppUF1yHNvkowid5BvOJgTAvg/b+LvgHt7WnqQUF6IvM4pzxnYZMS599brIokLkiqOn8DLVJvBd 2YwAfNkfFSQPacpQ5nIDgg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJD6D-00014D-8P; Sat, 21 Jan 2023 07:35:58 -0500 In-Reply-To: <87tu0k3y6t.fsf@thornhill.no> (message from Theodor Thornhill on Sat, 21 Jan 2023 12:48:58 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253856 Archived-At: > From: Theodor Thornhill > Cc: Yuan Fu > Date: Sat, 21 Jan 2023 12:48:58 +0100 > > Eli Zaretskii writes: > > > . How does one change the indentation style in c-ts-mode? > > > > - There is a defcustom c-ts-mode-indent-style, but I don't think I > > see any difference in indentation of new code when I change the > > value. What am I missing? > > > > (setq c-ts-mode-indent-style 'bsd) then revert-buffer fixes it for me. > It seems you need to reload the file to enable the new style. Should I > add a command that can be set explicitly as in c-mode? > 'c-ts-mode-set-style'? I think we need both a command and a :set function for the defcustom. > However, going over it I see there are lots of regressions after the new > bracket-counting code added recently, effectively making the indent > styles pretty broken right now... That's a separate issue, and I'm sure it will be fixed. And adding tests to the test suite will prevent us from breaking it too easily in the future. > > . What commands are affected by treesit-defun-tactic? > > 'treesit--navigate-thing' uses it, so 'beginning-of-defun', > 'forward-sentence' etc uses it through 'treesit-beginning-of-thing'. What commands except those that call treesit--navigate-thing call beginning-of-defun and treesit-beginning-of-thing?