From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Mon, 30 Jan 2023 14:41:52 +0200 Message-ID: <83mt605h4f.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> <83r0vkgj7l.fsf@gnu.org> <87h6wawo2k.fsf@gmail.com> <831qnea5ye.fsf@gnu.org> <87357t2xyh.fsf@gmail.com> <83k01573hz.fsf@gnu.org> <87v8kpj6ea.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16187"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org, juri@linkov.net To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 13:43:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMTVV-00045Q-C4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 13:43:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMTV7-0000EQ-JO; Mon, 30 Jan 2023 07:43:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMTV0-0000DP-OU for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 07:43:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMTV0-0006Sv-Fw for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 07:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMTUz-0000oU-SM for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 07:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.16750825273037 (code B ref 60841); Mon, 30 Jan 2023 12:43:01 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 30 Jan 2023 12:42:07 +0000 Original-Received: from localhost ([127.0.0.1]:46581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMTU7-0000mu-9x for submit@debbugs.gnu.org; Mon, 30 Jan 2023 07:42:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMTU6-0000mM-38 for 60841@debbugs.gnu.org; Mon, 30 Jan 2023 07:42:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMTU0-0006P9-22; Mon, 30 Jan 2023 07:42:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gKqMJ6UaT4F9OGorXl8ot+hvFFtIkPG506RQ8DHF5ks=; b=jYEP6iL12DWSATEPF2TV v8NXC2fGX1nBukJ+StBmvVVv5VovvXfB9bzP8RNPzW/Bu+MarabYwyc40Ppne2B7EcSvHsQg2B0E0 RAA+r7x+If0R1oz6d3VwOHDjBOCBwzjMamAmzvQQUplCuuc3OAi/yeF93IReTkHeFgKsPAljYinpe m0dwK/d0pPR7nXT9AOvF4GNaxkLETrGyzsrC7tZD5BGJDx+u+BUatexpaLUz3mZpa5tpVMERa6i9a wsiBku3WsjSrTP1tcGGZ2vptdsL1gObDUqedvhVHeKWMsTIQBVFdDuNQ6aignfTIvsdMAPYJ59Vpz CLoYriWtNsrxyw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMTTz-00049A-2f; Mon, 30 Jan 2023 07:41:59 -0500 In-Reply-To: <87v8kpj6ea.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Sun, 29 Jan 2023 23:57:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254413 Archived-At: > From: Kévin Le Gouguec > Cc: gregory@heytings.org, 60841@debbugs.gnu.org, juri@linkov.net > Date: Sun, 29 Jan 2023 23:57:33 +0100 > > > So we need to treat :stipple specially, or maybe fix merge_face_ref to > > allow the nil value. > > You mean something like the following? Yes. > OT1H that's the kind of sleeping dragon that I wouldn't want to tickle, > OTOH I see that other spots in the code seem to accept QCstipple mapping > to a NILP value: Exactly. The nil value is also documented as a valid one. So we must make that change in xfaces.c. > >From d767d5c658278bb102dea9a716da7a04dccb34aa Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= > Date: Sun, 29 Jan 2023 11:23:01 +0100 > Subject: [PATCH] Avoid spurious pause in kill-ring-save (Bug#60841) > > 'indicate-copied-region' checks whether the region is "highlighted" > and if not, briefly moves point to mark to give a visual cue of the > extent of text that was saved to the kill ring. > > The region is considered "highlighted" if (a) it is active and (b) its > face specifies a :background. That latter condition does not account > for the multiple ways in which the face can make the region "visually > distinct" from the default face, so switch to a more extensive > predicate. > > * lisp/faces.el (face-differs-from-default-p): Filter out :extend; add > rationale for the attributes we ignore. > * lisp/simple.el (copy-region-blink-predicate): Add option to let user > explicitly opt into or out of blinking point and mark. > (region-indistinguishable-p): New function to detect > "if there is currently no active region highlighting", leveraging > face-differs-from-default-p. > (indicate-copied-region): Use it. > * etc/NEWS: Announce user option. Please add the xfaces.c change, and then this can go in (to the emacs-29 branch). Thanks.