From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node Date: Wed, 01 Mar 2023 15:27:26 +0200 Message-ID: <83mt4wfvpd.fsf@gnu.org> References: <9FCDA5B7-D216-45B1-8051-35B05633BEFB@gmail.com> <83sfeukwsb.fsf@gnu.org> <574817C4-3FD8-43EA-B53C-B2BCB60A6D0A@gmail.com> <83mt51j6mv.fsf@gnu.org> <83a60xhou5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, casouri@gmail.com, mickey@masteringemacs.org, 60237@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 01 14:28:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXMVU-0002Mg-Cf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Mar 2023 14:28:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXMV2-0008Qv-RB; Wed, 01 Mar 2023 08:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXMV0-0008QF-AS for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 08:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXMV0-0003ct-2Z for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 08:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXMUz-0001aw-R4 for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 08:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Mar 2023 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60237 X-GNU-PR-Package: emacs Original-Received: via spool by 60237-submit@debbugs.gnu.org id=B60237.16776772456084 (code B ref 60237); Wed, 01 Mar 2023 13:28:01 +0000 Original-Received: (at 60237) by debbugs.gnu.org; 1 Mar 2023 13:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:53004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXMUO-0001a3-Pe for submit@debbugs.gnu.org; Wed, 01 Mar 2023 08:27:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXMUN-0001Zq-51 for 60237@debbugs.gnu.org; Wed, 01 Mar 2023 08:27:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXMUG-0003WX-Kw; Wed, 01 Mar 2023 08:27:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Buw+FWu6Y4em648Ykoo3+WufzUD4GCn29nD0vSa63WA=; b=FAaI2TxZyU4+ W+pr2A0p4Uv7KR1jOvADtnZLDkQ5/r9K8+tE6u0MljqbGNU7YLe4W+kpo1HbBs569kmDEMhNFIA7o GdJvEEQILemFIXN8aAlaDOdT6kJ1eR9Q1cZh19NUIFP8Z6X57kYd/Hwoazw5vje938BxOJVLre+Tv fCquaRBtr3oxk0yVCYHNnGNjqVK15jJ+/IiQX+XSqCPaFwtaEEDFW6lmeX1MAjMItQ35j8h+Llum8 FIPryszTdU0NYY8dGtod/cVu4gSqp7Fvb7QVQoOBpPiGWGnO15Ah1wdin3M/FwwY5mKi7mFCz2P89 z2siemBHD4nZb60utJ+9eA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXMUD-0001E2-7d; Wed, 01 Mar 2023 08:27:16 -0500 In-Reply-To: (message from Stefan Monnier on Tue, 28 Feb 2023 23:07:47 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257061 Archived-At: > From: Stefan Monnier > Cc: casouri@gmail.com, luangruo@yahoo.com, mickey@masteringemacs.org, > 60237@debbugs.gnu.org > Date: Tue, 28 Feb 2023 23:07:47 -0500 > > >> > Stefan, could it be a problem for us if garbage-collecting an object > >> > calls xmalloc? Including if the "memory" profiler is running at the > >> > time of that GC? > >> > >> I can't think of a fundamental reason why this would be a problem, but > >> as you've seen some code may not be quite ready for it. > >> > >> I suspect the simplest solution is to do something like what we do > >> for the cpu-profiler, i.e. handle the "time within GC" specially by > >> checking (EQ (backtrace_top_function (), QAutomatic_GC)) to determine > >> that we're within the GC. > > > > Any reason not to install the patch that uses gcsize instead of ASIZE? > > That might work, but I suspect there's a good reason why I used > `cpu_gc_count`. I think running the "normal" profiling code during GC > can cause other problems than just ASIZE because it can/will change > ELisp objects, and modifying the heap while we're doing GC is the > problem that concurrent GCs try to solve: our GC is not equipped > for that. Would you mind installing a change along these lines on the emacs-29 branch? I'm not familiar enough with profiler.c to experiment with its code on the release branch. TIA