From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 62420@debbugs.gnu.org
Subject: bug#62420: 29.0.60; fns-tests-collate-strings fails on Cygwin
Date: Sat, 25 Mar 2023 15:24:29 +0300 [thread overview]
Message-ID: <83mt41c936.fsf@gnu.org> (raw)
In-Reply-To: <b66fd2be-4b20-bc02-67d9-15aaf0a66b7a@cornell.edu> (message from Ken Brown on Fri, 24 Mar 2023 10:52:45 -0400)
> Date: Fri, 24 Mar 2023 10:52:45 -0400
> From: Ken Brown <kbrown@cornell.edu>
>
> The reason is that en_DE.UTF-8 is actually a valid locale on Cygwin.
> [Cygwin gets its locale information from Windows. The latter supports
> the RFC 5646 locale "en-DE", which is called "English (Germany)" in the
> "Region" settings.]
>
> The following trivial patch fixes the problem:
>
> --- a/test/src/fns-tests.el
> +++ b/test/src/fns-tests.el
> @@ -254,7 +254,7 @@ fns-tests-collate-strings
> (should (string-collate-equalp "xyzzy" "XYZZY" nil t))
> ;; Locale must be valid.
> - (should-error (string-collate-equalp "xyzzy" "xyzzy" "en_DE.UTF-8")))
> + (should-error (string-collate-equalp "xyzzy" "xyzzy" "en_XY.UTF-8")))
> ;; There must be a check for valid codepoints. (Check not
> implemented yet)
> ; (should-error
>
>
> Is this OK for the emacs-29 branch?
Yes, thanks.
> [Note: The test will still fail on current Cygwin after this patch; but
> that's because of a bug in Cygwin, which has been fixed in the
> development sources for Cygwin 3.5.]
Maybe mention this in comments? Bonus points for making it an
expected failure for Cygwin < 3.5, assuming the version of Cygwin
could be obtained by the test code.
next prev parent reply other threads:[~2023-03-25 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 14:52 bug#62420: 29.0.60; fns-tests-collate-strings fails on Cygwin Ken Brown
2023-03-25 12:24 ` Eli Zaretskii [this message]
2023-03-25 14:27 ` Ken Brown
2023-03-25 14:46 ` Eli Zaretskii
2023-03-25 15:02 ` Corwin Brust
2023-03-25 15:14 ` Ken Brown
2023-03-25 15:49 ` Eli Zaretskii
2023-03-25 16:47 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt41c936.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62420@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.