From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 67ab357cdcc 7/7: Support treesit-thing-settings in search functions Date: Sat, 15 Apr 2023 09:58:09 +0300 Message-ID: <83mt39einy.fsf@gnu.org> References: <168151708682.12577.9938116109918336537@vcs2.savannah.gnu.org> <20230415000448.67F57C13A82@vcs2.savannah.gnu.org> <874jphkgqe.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, casouri@gmail.com To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 15 08:59:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnZsM-0004gu-09 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Apr 2023 08:59:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnZrQ-0007FJ-5P; Sat, 15 Apr 2023 02:58:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnZrO-0007FA-5w for emacs-devel@gnu.org; Sat, 15 Apr 2023 02:58:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnZrN-0006B4-Sc; Sat, 15 Apr 2023 02:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yCwRiA/G3jFMIbES9egVPUWWwScsjPYFbQHRx2hvsoY=; b=QO8miH5A7Sft S7yv0tsanFMMa5LnO1jJNKuzzK/tIRindU5+VgU+1tWrTwU6camgIkQeX0wncW5M2cWzJFd9vVTeF otMYjNDKbEga/Jcj6nj8myGnjrN2gFlmCFF3Xesz5N6F5jB8SIpqBzSW9w2SJRk/vqWuTe7LlDVtv FTnaPFyTjg5f+5Y/KLp+N/wivJikpmWiMR7dE14BPyV5ZtBAxOngQiHQCxSF6myQ3P9mVOWc4x2fK 4TcYXYkkW0mdGTNDdbV/ecyLt9y+oIn41v/c6XCbCFzaV3LDtlHyAOfu+yJVZsEgqinlb/QNG3NJb MiUHHGk9EwGYsjLGZ90rMA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnZrN-0006Bo-3m; Sat, 15 Apr 2023 02:58:09 -0400 In-Reply-To: <874jphkgqe.fsf@yahoo.com> (message from Po Lu on Sat, 15 Apr 2023 10:43:21 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305322 Archived-At: > From: Po Lu > Cc: Yuan Fu > Date: Sat, 15 Apr 2023 10:43:21 +0800 > > Yuan Fu writes: > > > +/* Assq but doesn't signal. */ > > +static Lisp_Object > > +safe_assq (Lisp_Object key, Lisp_Object alist) > > +{ > > + Lisp_Object tail = alist; > > + FOR_EACH_TAIL_SAFE (tail) > > + if (CONSP (XCAR (tail)) && EQ (XCAR (XCAR (tail)), key)) > > + return XCAR (tail); > > + return Qnil; > > +} > > Please, write more descriptive doc strings. I would write: > > /* Like `assq_no_quit', except it avoids chasing after circular > lists. */ It is more efficient to just go ahead and make minor changes like that, than start discussions about them. Thanks.