From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: sbaugh@catern.com, 62958@debbugs.gnu.org
Subject: bug#62958: [PATCH] Set PAGER=cat in comint.el
Date: Tue, 09 May 2023 21:58:06 +0300 [thread overview]
Message-ID: <83mt2d9vsx.fsf@gnu.org> (raw)
In-Reply-To: <ier1qjptokr.fsf@janestreet.com> (message from Spencer Baugh on Tue, 09 May 2023 13:13:56 -0400)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: sbaugh@catern.com, 62958@debbugs.gnu.org
> Date: Tue, 09 May 2023 13:13:56 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Spencer Baugh <sbaugh@janestreet.com>
> >> Date: Tue, 9 May 2023 13:01:07 -0400
> >> Cc: sbaugh@catern.com, 62958@debbugs.gnu.org
> >>
> >> I'm asking why this is not already obvious from the fact that this is
> >> a defcustom, by default off. All your addition says is "don't disable
> >> paging in all cases, sometimes it can be useful". But we already said
> >> that, in effect, by making the paging enabled by default. So there's
> >> no reason to have that text, as it isn't instrumental, and doesn't add
> >> anything.
> >>
> >> How does "this is a defcustom, by default off" communicate "you should use vc-print-log if you turn this
> >> on"?
> >
> > Why are we suddenly talking about vc-print-log when discussing a much
> > more general feature?
>
> Because disabling pagination effectively breaks the shell command "git
> log" and vc-print-log is one alternative to running "git log", and I
> don't know how else the user would realize that. (In my experience with
> talking to users about this, they usually don't)
A doc string of a general option is not the proper place for talking
about some very specific case when that option is used. If the main
problem is vc-print-log, we should find another way of dealing with
it.
next prev parent reply other threads:[~2023-05-09 18:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 21:57 bug#62958: [PATCH] Set PAGER=cat in comint.el Spencer Baugh
2023-04-20 6:43 ` Eli Zaretskii
2023-04-20 15:47 ` Spencer Baugh
2023-04-20 15:56 ` Eli Zaretskii
2023-04-20 16:01 ` Spencer Baugh
2023-05-05 6:35 ` Eli Zaretskii
2023-05-08 19:38 ` Spencer Baugh
2023-05-09 5:08 ` Eli Zaretskii
2023-05-09 14:55 ` sbaugh
2023-05-09 15:46 ` Eli Zaretskii
2023-05-09 16:30 ` Spencer Baugh
2023-05-09 16:43 ` Eli Zaretskii
2023-05-09 16:53 ` Spencer Baugh
2023-05-09 16:59 ` Eli Zaretskii
2023-05-09 17:01 ` Spencer Baugh
2023-05-09 17:05 ` Eli Zaretskii
2023-05-09 17:13 ` Spencer Baugh
2023-05-09 18:58 ` Eli Zaretskii [this message]
2023-05-16 19:49 ` Spencer Baugh
2023-05-17 11:32 ` Eli Zaretskii
2023-05-17 14:55 ` Spencer Baugh
2023-05-19 6:09 ` Eli Zaretskii
2023-05-26 11:31 ` Eli Zaretskii
2023-05-09 17:03 ` Eli Zaretskii
2023-05-10 16:39 ` Juri Linkov
2023-05-10 16:59 ` Eli Zaretskii
2023-05-10 18:13 ` Gregory Heytings
2023-05-12 17:49 ` Juri Linkov
2023-05-12 22:21 ` Gregory Heytings
2023-04-26 7:54 ` Philip Kaludercic
2023-04-26 9:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt2d9vsx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62958@debbugs.gnu.org \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.