From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Wed, 28 Jun 2023 14:46:45 +0300 Message-ID: <83mt0jvmfu.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="913"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org To: Vladimir Sedach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 28 13:47:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qETdu-000AVS-97 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Jun 2023 13:47:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qETdY-0004zF-Q5; Wed, 28 Jun 2023 07:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETdW-0004iv-A5 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qETdV-0005xY-V4 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qETdV-0004KT-Lg for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2023 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168795278916581 (code B ref 64311); Wed, 28 Jun 2023 11:47:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 28 Jun 2023 11:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:50149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qETcz-0004JN-60 for submit@debbugs.gnu.org; Wed, 28 Jun 2023 07:46:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qETcx-0004J8-U8 for 64311@debbugs.gnu.org; Wed, 28 Jun 2023 07:46:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETcr-0005d1-Dw; Wed, 28 Jun 2023 07:46:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=L0DzRaqEAmti5d7iJETKYJ7y+f2bBhIA50K9McSAXDA=; b=e9R8jlgWlAe6 0BvmHGJ5Ub4lsn9rFzrOl2/apU4g37HrgWiLg2th/V8dXs9qKui4k1Ak2DxaS8pUZpcfCqmWhBGKS I61/V8Jsl9hXH65ZY+eM/wpPukLpH5ZLvhkKUu/TF8eVHplNE6O/mcEIXx0dSwzX27m4M8oZwfKiA 00WUzuobBgj6qZW7YW447E3HArnpWtaEPKb1f2kJvXigMSDHkOkLDr++M6Mh6fTbfCghg5IyTkedK 2Nuvo+PbLjYiPbVqDftkGNbAPMlSDbOcl/WjX6ElSCoPb35sYMEOvhzUns/TTwdAn7xsbRp1aNoTT FUh/JunamNTAK4rmfz879g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETcq-0004xR-U5; Wed, 28 Jun 2023 07:46:21 -0400 In-Reply-To: <87zg4k76es.fsf@orphne.orion.oneofus.la> (message from Vladimir Sedach on Tue, 27 Jun 2023 18:07:27 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264205 Archived-At: > From: Vladimir Sedach > Cc: 64311@debbugs.gnu.org > Date: Tue, 27 Jun 2023 18:07:27 -0600 > > > Eli Zaretskii writes: > > > In any case, I don't think a fix (if we need one) should be so > > complicated. Why do we need all those changes, including making the > > variable obsolete and moving the mode from its place in shell.el to > > another place there? If all you want is to make this variable > > buffer-local, just making it buffer-local is all that's needed, > > right? > > shell-dirtrack-mode is already made buffer-local by > define-minor-mode. > > The problem is shell-dirtrackp and its default value. So if we make it also buffer-local, the problem is gone, no?