From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Thu, 13 Jul 2023 22:03:20 +0300 Message-ID: <83mszz4osn.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83v8eo3pfv.fsf@gnu.org> <87edlbd90e.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 21:04:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK1bo-0008rE-2O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 21:04:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK1bh-0003SZ-7Z; Thu, 13 Jul 2023 15:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1be-0003SM-RK for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:04:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK1be-0001GW-JL for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK1be-0003Tv-EL for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168927499113309 (code B ref 64596); Thu, 13 Jul 2023 19:04:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 13 Jul 2023 19:03:11 +0000 Original-Received: from localhost ([127.0.0.1]:40873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK1ap-0003Sb-2p for submit@debbugs.gnu.org; Thu, 13 Jul 2023 15:03:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK1am-0003SN-7h for 64596@debbugs.gnu.org; Thu, 13 Jul 2023 15:03:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1ah-0000fX-1A; Thu, 13 Jul 2023 15:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=meeLW4IXkmdzb/jqqtk3Ok+hqewuvzeUNWMJ1FvHDqY=; b=fFB20TUtgrLW r6SnJo048UxLmnG1wXdXGymiIIV90Y71gBopxHVQSi/HixwjsW01M+rA+g+h3/1SmNwWzmbLhM2aM Bzri20vTSVikDMwwI/e22RM/0C97phksNekkqBug+sY/V3YRZvPTo7h2A8kstIPgtt/5jKrGU+4s0 llJ/Iuc2zMxBV7bryBpG7EQnTjj3bTlVhaW73X/eoEGvDMr7cJ7ZHF6zO8QKPAksOtPml5Hl1uOrm YSlSL1i4Hfg3em0oZdb+A/mRB4bKP0PRum2luJRKa5gXPzsWB4Il2xZjoQr09DlS2lIoMKJs21zg1 SLFpNgRFbsMDz6F7Zu723g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1ag-0001nb-G2; Thu, 13 Jul 2023 15:03:02 -0400 In-Reply-To: <87edlbd90e.fsf@localhost> (message from Ihor Radchenko on Thu, 13 Jul 2023 17:19:29 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265044 Archived-At: > From: Ihor Radchenko > Cc: Stefan Monnier , 64596@debbugs.gnu.org > Date: Thu, 13 Jul 2023 17:19:29 +0000 > > Eli Zaretskii writes: > > > The purpose of force-mode-line-update is to do what its name says, > > regardless of whether the buffer was modified or not, and how it was > > modified. The idea is that Lisp programs which change something that > > they know must affect the mode line call this function to make sure > > the mode line is redrawn with up-to-date information. > > I do not claim that I fully understand Who does, when it comes to the display code? > but what is confusing is that a number of other places in code > simply use bset_update_mode_line without disabling optimizations. In > particular: > > 1. kill-all-local-variables > 2. rename-buffer bset_update_mode_line is for a single buffer, whereas the FIXME is for the case where force-mode-line-update is called with a non-nil ALL argument. > Also, `force-window-update' disable optimizations for a given window, > but not when all windows should be updated - in contrast with the code > in OP. When all the windows need to be updated, we force that via windows_or_buffers_changed, which is a somewhat stronger flag, as far as preventing optimizations goes. > So, `force-window-update' and `force-mode-line-update' are at least > inconsistent. Why should they be entirely consistent? They do different jobs.