From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65666: Lockfiles break package-vc-install-from-checkout Date: Sat, 02 Sep 2023 10:49:38 +0300 Message-ID: <83msy59fql.fsf@gnu.org> References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> <87o7imvywn.fsf@posteo.net> <87ledpmp8f.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 09:51:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcLPR-0004dZ-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 09:51:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcLPF-0006bd-NZ; Sat, 02 Sep 2023 03:50:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLPA-0006a0-BP for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:50:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcLPA-0005W0-25 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:50:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcLPJ-0004GM-Kj for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 07:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65666 X-GNU-PR-Package: emacs Original-Received: via spool by 65666-submit@debbugs.gnu.org id=B65666.169364100916313 (code B ref 65666); Sat, 02 Sep 2023 07:51:01 +0000 Original-Received: (at 65666) by debbugs.gnu.org; 2 Sep 2023 07:50:09 +0000 Original-Received: from localhost ([127.0.0.1]:35064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLOT-0004F3-0N for submit@debbugs.gnu.org; Sat, 02 Sep 2023 03:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLOQ-0004EN-Iu for 65666@debbugs.gnu.org; Sat, 02 Sep 2023 03:50:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLOB-0004zP-26; Sat, 02 Sep 2023 03:49:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GfSBIsb5WlT9P6MAw6gXTBolSVPex/s0zH/YbfTqj4k=; b=TVSsUuOydGLq 29G/YoK8X4vvkNcyserDN7nLRIlHjh+GUnqgAc7+VaO/hlQChpdrrQ5ewTx+MLfw3SAzwtXzqStPq h/C82FTlEfcxCu84LvhWh+taZc9CwibMN0gN+VD9xtyKNiOa4dFKSuthsSUrdzgUXApTZ9okXPm9r S6dmDa/oQzDB2yiKA+cb/PvZo4oBOrOatCa8wUH3xDOBifzqVu6058rLQu9R4DI+c+2gwEdxCTAdE XSXDH1wdvSRlUd7H6GefJ6AlWm6FcaXBnAWCzEMFY1lhsQ07v//OvI+d+tjVFUyJjUU4W65vXJhrk ImWPda/2Wl8IL9TNxUSUiw==; In-Reply-To: <87ledpmp8f.fsf@breatheoutbreathe.in> (message from Joseph Turner on Fri, 01 Sep 2023 16:43:27 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268964 Archived-At: > From: Joseph Turner > Cc: Eli Zaretskii , 65666@debbugs.gnu.org, adam.porter@47ap.net > Date: Fri, 01 Sep 2023 16:43:27 -0700 > > > Philip Kaludercic writes: > > > LGTM, but I wonder if there is a better way to detect lockfiles > > specifically? If not, I can imagine that just using `file-exists-p' > > would a too broad check, in the sense that it could make it difficult to > > find other issues? > > We could use a regex like > > (unless (string-match-p (rx string-start ".#") file)) Or make the REGEXP argument to directory-files-recursively more specific, to reject lock files. But yes, the use of file-exists-p is not TRT, IMO.