From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67269: 30.0.50; italic face fallback does not assume italic properties Date: Sat, 25 Nov 2023 12:31:16 +0200 Message-ID: <83msv2ceff.fsf@gnu.org> References: <87jzqejn8f.fsf.ref@yahoo.com> <87jzqejn8f.fsf@yahoo.com> <83leaul03g.fsf@gnu.org> <87bkbqjk97.fsf@yahoo.com> <83h6likvgc.fsf@gnu.org> <8734x1kjg1.fsf@yahoo.com> <83wmudkihf.fsf@gnu.org> <838r6sk5b5.fsf@gnu.org> <87ttpgiqhn.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67269-done@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 11:32:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6pxR-0001fU-Uw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 11:32:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6pxA-0004gu-9g; Sat, 25 Nov 2023 05:32:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6px7-0004gA-VO for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:31:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6px7-0001nc-Nb for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:31:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6pxC-0005d8-MK for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:32:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 10:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67269 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Mail-Followup-To: 67269@debbugs.gnu.org, eliz@gnu.org, luangruo@yahoo.com Original-Received: via spool by 67269-done@debbugs.gnu.org id=D67269.170090829421595 (code D ref 67269); Sat, 25 Nov 2023 10:32:02 +0000 Original-Received: (at 67269-done) by debbugs.gnu.org; 25 Nov 2023 10:31:34 +0000 Original-Received: from localhost ([127.0.0.1]:37922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6pwk-0005cF-4N for submit@debbugs.gnu.org; Sat, 25 Nov 2023 05:31:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6pwg-0005c0-U2 for 67269-done@debbugs.gnu.org; Sat, 25 Nov 2023 05:31:31 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6pwW-0001mT-69; Sat, 25 Nov 2023 05:31:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uBLyq2GKf72GnAos1Qtg8n9rFbF3o3GfcAvRWxU32c0=; b=o9ObhBxhXZ1J 85IobP450C2oFgTn+erDq3t4g0uoVn6/4131CyIe7UVoKzqKrENmwen5Mw9EAl0TDL1LWTMfHa9s+ HeQI5QTEKzwLOYkqLnawmbfIEqgix6TFf5PUg5JjXrD1KgnEhn2tJoQ5gXQzdVtUP8dU/pDJXdjMQ 096y76Tzog68iA05lFxHkY7uqagpqCaYKKy11Dn6tVy3dIvhDuHHfEjRyhf0sLdAqoU7izGlrqGxU +DRm2FJ/VoNcV3qETKaJtTxshaPvYB4dS2+dfhRsH8N6INEWCwyvkDdoZCOH9FQHSdCsC5p2t1dMU 9GOTzenvxi4pITTBwlnVYw==; In-Reply-To: <87ttpgiqhn.fsf@yahoo.com> (message from Po Lu on Mon, 20 Nov 2023 20:00:36 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274949 Archived-At: > From: Po Lu > Cc: 67269@debbugs.gnu.org > Date: Mon, 20 Nov 2023 20:00:36 +0800 > > Eli Zaretskii writes: > > > If so, then it is strange that we haven't heard about this issue > > before. > > > > Maybe we should do something like the below, and leave the rest to end > > users and downstream distros. > > > >> > I don't understand how shr-tag-i is relevant. I'm probably missing > >> > something. > >> > >> It combines a variable pitch face with italic, and so loses when the > >> italic face doesn't support slant properties, even if the variable pitch > >> one does. > > > > Yes, you already said that in your original message. I thought > > shr-tag-i provides some additional insight. > > Ah, I'm sorry for the misunderstanding then. > > > diff --git a/lisp/faces.el b/lisp/faces.el > > index 7eacc40..8eaabbf 100644 > > --- a/lisp/faces.el > > +++ b/lisp/faces.el > > @@ -2440,7 +2440,10 @@ italic > > '((((supports :slant italic)) > > :slant italic) > > (((supports :underline t)) > > - :underline t) > > + ;; Include italic, even if it isn't supported by the default > > + ;; font, because this face could be merged with another face > > + ;; which uses font that does have an italic variant. > > + :underline t :slant italic) > > (t > > ;; Default to italic, even if it doesn't appear to be supported, > > ;; because in some cases the display engine will do its own > > @@ -2457,7 +2460,9 @@ bold-italic > > (defface underline > > '((((supports :underline t)) > > :underline t) > > - (((supports :weight bold)) > > + ;; Include underline, for when this face is merged with another > > + ;; whose font does support underline. > > + (((supports :weight bold :underline t)) > > :weight bold) > > (t :underline t)) > > "Basic underlined face." > > That's alright by me, thanks. Thanks, installed on master, and closing the bug.