From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 67269-done@debbugs.gnu.org
Subject: bug#67269: 30.0.50; italic face fallback does not assume italic properties
Date: Sat, 25 Nov 2023 12:31:16 +0200 [thread overview]
Message-ID: <83msv2ceff.fsf@gnu.org> (raw)
In-Reply-To: <87ttpgiqhn.fsf@yahoo.com> (message from Po Lu on Mon, 20 Nov 2023 20:00:36 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: 67269@debbugs.gnu.org
> Date: Mon, 20 Nov 2023 20:00:36 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > If so, then it is strange that we haven't heard about this issue
> > before.
> >
> > Maybe we should do something like the below, and leave the rest to end
> > users and downstream distros.
> >
> >> > I don't understand how shr-tag-i is relevant. I'm probably missing
> >> > something.
> >>
> >> It combines a variable pitch face with italic, and so loses when the
> >> italic face doesn't support slant properties, even if the variable pitch
> >> one does.
> >
> > Yes, you already said that in your original message. I thought
> > shr-tag-i provides some additional insight.
>
> Ah, I'm sorry for the misunderstanding then.
>
> > diff --git a/lisp/faces.el b/lisp/faces.el
> > index 7eacc40..8eaabbf 100644
> > --- a/lisp/faces.el
> > +++ b/lisp/faces.el
> > @@ -2440,7 +2440,10 @@ italic
> > '((((supports :slant italic))
> > :slant italic)
> > (((supports :underline t))
> > - :underline t)
> > + ;; Include italic, even if it isn't supported by the default
> > + ;; font, because this face could be merged with another face
> > + ;; which uses font that does have an italic variant.
> > + :underline t :slant italic)
> > (t
> > ;; Default to italic, even if it doesn't appear to be supported,
> > ;; because in some cases the display engine will do its own
> > @@ -2457,7 +2460,9 @@ bold-italic
> > (defface underline
> > '((((supports :underline t))
> > :underline t)
> > - (((supports :weight bold))
> > + ;; Include underline, for when this face is merged with another
> > + ;; whose font does support underline.
> > + (((supports :weight bold :underline t))
> > :weight bold)
> > (t :underline t))
> > "Basic underlined face."
>
> That's alright by me, thanks.
Thanks, installed on master, and closing the bug.
prev parent reply other threads:[~2023-11-25 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87jzqejn8f.fsf.ref@yahoo.com>
2023-11-19 6:01 ` bug#67269: 30.0.50; italic face fallback does not assume italic properties Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 6:37 ` Eli Zaretskii
2023-11-19 7:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 8:18 ` Eli Zaretskii
2023-11-19 12:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 12:58 ` Eli Zaretskii
2023-11-20 0:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 11:55 ` Eli Zaretskii
2023-11-20 12:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 10:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83msv2ceff.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67269-done@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.