From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Turning on savehist-mode by default Date: Sun, 17 Dec 2023 14:11:28 +0200 Message-ID: <83msu9jafj.fsf@gnu.org> References: <461a0999-6005-4aa4-a4b3-988123855f92@alphapapa.net> <831qbll01p.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9955"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org, sbaugh@catern.com, stefankangas@gmail.com To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 17 13:12:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEq05-0002Ku-4y for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Dec 2023 13:12:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEpzq-0003XL-5T; Sun, 17 Dec 2023 07:11:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpzm-0003X9-Qc for emacs-devel@gnu.org; Sun, 17 Dec 2023 07:11:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpzk-0006Fa-Hm; Sun, 17 Dec 2023 07:11:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sggfvZecN+XY6GLcoYm/AOB7hOVSZZF5+tvD/B3xXLY=; b=h0WRKTZLGTVd URLmicfeBUGvLq8jj1yp/THMeQJ+XEBTvZTPVgx1PaJFgpXzlONvN4aa0/lBRIZfXHDvdF0pQPv7D 9UGz5h3+k1EqOx2AX9uzfTp1UzYCKhhkPgwP7WkPecdjuLvvMBG1eZ2zeFnKVWejtZj5U0aTNsITH hXUWIKcE78n51eM5wYUsvhpnmnSksAAIs0e27277wPjOVZi7z3McvZf4orSj85lPJJfIaTSOoQBSY DtidXp20dP9g66UmEla9ziV+QvQOX8I/8MTnz2gb3h75A18MDf2Qxel1XDfIRPnqDzaVQGvXbp+NW tQ4/zbKYoP90aiip/shOqA==; In-Reply-To: (message from Adam Porter on Sun, 17 Dec 2023 05:19:31 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313922 Archived-At: > Date: Sun, 17 Dec 2023 05:19:31 -0600 > Cc: luangruo@yahoo.com, emacs-devel@gnu.org, sbaugh@catern.com, > stefankangas@gmail.com > From: Adam Porter > > On 12/17/23 02:12, Eli Zaretskii wrote: > > > > That mentions a single 3rd-party package that triggers the issue, and > > includes a workaround solution. I see nothing awful there. > > From my perspective, as the developer of the package being accused of > having performance problems by random users, problems I couldn't > reproduce, nor even begin to guess what the cause was, or if it was even > an actual problem, it felt pretty awful. Welcome to the club. I (and other maintainers) get that feeling almost every day. And yet I don't conclude from this that existing features are badly implemented or that they should be removed or turned off by default. Instead, we investigate the issues, find the problems, and either fix them or provide a workaround. So I see nothing special in the incident you referred to: it's what I see every day. > >> I'd guess that there are more such cases in the wild waiting to be > >> triggered. > > > > You know about other packages that add huge elements to history > > variables? Which ones? > > My package does not add huge elements to history variables. It simply > passes arguments to functions via their interactive forms. I didn't > even know that such history variables existed until that bug report came > to its conclusion, and I've used Emacs for years and published tens of > packages which together have nearly a million downloads. So if it can > happen to me, it can probably happen to anyone. That was not my question, sorry. My question was whether you are actually _aware_ of such problems happening in other cases with other packages. Because if not, a single instance is not yet a reason for considering this a grave problem, a reason serious enough to consider savehist flawed or immature.